Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add gource #7193

Merged
merged 16 commits into from
Mar 21, 2021
Merged

Add gource #7193

merged 16 commits into from
Mar 21, 2021

Conversation

koppor
Copy link
Member

@koppor koppor commented Dec 14, 2020

Gource nicely renders the history of our development

See for an example: https://www.youtube.com/watch?v=cFuZnzq97sQ

Refs JabRef/www.jabref.org#83

  • Change in CHANGELOG.md described (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked documentation: Is the information available and up to date? If not created an issue at https://github.com/JabRef/user-documentation/issues or, even better, submitted a pull request to the documentation repository.

@koppor koppor mentioned this pull request Dec 14, 2020
Closed
@Siedlerchr
Copy link
Member

Hm, but I don't see any file yet?

@NBprojekt
Copy link
Contributor

The output file is stored in the artefact
(download)

If you want to add the file to the repo, you'll need to do it in your own workflow. I could also give an example of how to do this.

@tobiasdiez
Copy link
Member

It's a nice gimmick, but what are we going to do with the produced movie?

@Siedlerchr
Copy link
Member

We should upload it to YouTube.

@koppor
Copy link
Member Author

koppor commented Dec 20, 2020

We should upload it to YouTube.

That's the plan. Have to inspect the length of the video. Maybe add a monthly video and an updated total one covering the whole history 😅

@Siedlerchr
Copy link
Member

Possible scripts for uploadiing: https://github.com/tokland/youtube-upload
https://github.com/TheMengzor/youtube-upload
Refs: https://developers.google.com/youtube/v3/guides/uploading_a_video

@koppor
Copy link
Member Author

koppor commented Dec 20, 2020

Automatic upload not possible.

  1. Server-to-Server authorization not availble for youtube. See last comment in 0 point answer: https://stackoverflow.com/q/29242851/873282
  2. Requested OAuth token has a live time for approx 2 hours. Then a manual browser usage is required.

@Siedlerchr
Copy link
Member

Action fails:

mv: cannot move './gource/gource.mp4' to './gource-videos/jabref-.mp4': Permission denied

@tobiasdiez
Copy link
Member

I would propose to only run this workflow via a manual trigger, that can be run from time to time (maybe after each release)?

@koppor
Copy link
Member Author

koppor commented Jan 2, 2021

I am trying to reduce the manual steps I have to do.

I can also read error messages.

Sorry that I spend the days between the years differently.

Would you guys mind to focus on other issues and PRs?

@koppor koppor marked this pull request as draft January 2, 2021 12:26
@koppor
Copy link
Member Author

koppor commented Jan 2, 2021

And sorry for not converting it to draft

@tobiasdiez
Copy link
Member

xkcd

Sorry, couldn't resist ;-)

@koppor
Copy link
Member Author

koppor commented Jan 18, 2021

DevCall: We do not upload video automatically, we just generate it. If that works "quickly" in this PR, we go ahead. Otherwise, we won't have any cool gource videos ^^.

@koppor koppor mentioned this pull request Mar 1, 2021
Closed
@tobiasdiez tobiasdiez added the status: changes required Pull requests that are not yet complete label Mar 10, 2021
@Siedlerchr
Copy link
Member

https://crontab.guru/#15_3_1_1,4,7,10_*

“At 03:15 on day-of-month 1 in January, April, July, and October.”

@Siedlerchr Siedlerchr removed the status: changes required Pull requests that are not yet complete label Mar 15, 2021
@Siedlerchr Siedlerchr marked this pull request as ready for review March 15, 2021 19:58
@calixtus
Copy link
Member

Maybe open an issue "upload to youtube" with a link to the created artifact?

@koppor
Copy link
Member Author

koppor commented Mar 21, 2021

Current output:

grafik

grafik

  • Q1 is ca. 30 seconds
  • complete is ca. 7 minutes

Will try to change the parameter so that the quarter report will also approx. 5 minutes.

@koppor
Copy link
Member Author

koppor commented Mar 21, 2021

“At 03:15 on day-of-month 1 in January, April, July, and October.”

The good thing is that GitHub UI provides a tooltip:

grafik

@koppor
Copy link
Member Author

koppor commented Mar 21, 2021

3:30 now. LGTM. I just merge. We can IMHO optimize as soon as we have done the other important things ^^.

@koppor koppor merged commit 7479f9c into master Mar 21, 2021
@koppor koppor deleted the gource branch March 21, 2021 22:10
Siedlerchr added a commit that referenced this pull request Mar 28, 2021
@Siedlerchr
Merge remote-tracking branch 'upstream/master' into writebackupToTemp
f99ba6f 
* upstream/master: (191 commits)
  Fix for issue 7416: font size of the preferences dialog does not update with the rest of the GUI. (#7509)
  Fix school/instituation is printed twice (#7574)
  Dsiable notarisation until we hae an account for JabRef e.V. (#7572)
  Fix citation keys unintentionally being overwritten on import (#7443)
  Fix AuthentificationPlugin not declared in mergedModule (#7570)
  Suggestions for changes in caching latex free authors (#7301)
  Add simple Unit Tests (#7542)
  Fix drag and drop into empty library (#7555)
  Bump richtextfx from 0.10.4 to 0.10.6 (#7563)
  Bump pdfbox from 2.0.22 to 2.0.23 (#7561)
  Bump org.eclipse.jgit (#7560)
  Bump fontbox from 2.0.22 to 2.0.23 (#7562)
  Bump guava from 30.1-jre to 30.1.1-jre (#7564)
  Bump xmpbox from 2.0.22 to 2.0.23 (#7565)
  Bump hmarr/auto-approve-action from v2.0.0 to v2.1.0 (#7566)
  Add gource (#7193)
  UI: Fix for group icon (#7552)
  Fix for issue 6487: Opening BibTex file (doubleclick) from Folder with spaces not working (#7551)
  add ability to insert arxivId (#7549)
  Fixed missing trigger for linked file operations (#7548)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NBprojekt NBprojekt NBprojekt left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@koppor @Siedlerchr @NBprojekt @tobiasdiez @calixtus