Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added error msg when isbn entry was not found #7036

Merged
merged 3 commits into from
Oct 22, 2020
Merged

Added error msg when isbn entry was not found #7036

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f31a2d3
add error msg when isbn entry not found
tmrd993 Oct 22, 2020
06ff696
move error dialog to EntryTypeViewModel, add changelog entry
tmrd993 Oct 22, 2020
a951fa0
Update CHANGELOG.md
calixtus Oct 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ Note that this project **does not** adhere to [Semantic Versioning](http://semve
- We added a DOI format and organization check to detect [American Physical Society](https://journals.aps.org/) journals to copy the article ID
to the page field for cases where the page numbers are missing. [#7019](https://github.com/JabRef/jabref/issues/7019)
- We added a new fetcher to enable users to search jstor.org [#6627](https://github.com/JabRef/jabref/issues/6627)
- We added an error message in the New Entry dialog that is shown in case the fetcher did not find anything . [#7000](https://github.com/JabRef/jabref/issues/7000)

### Changed

Expand Down
4 changes: 4 additions & 0 deletions src/main/java/org/jabref/gui/EntryTypeViewModel.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,6 +176,10 @@ public void runFetcherWorker() {
searchSuccesfulProperty.set(true);
} else if (StringUtil.isBlank(idText.getValue())) {
dialogService.showWarningDialogAndWait(Localization.lang("Empty search ID"), Localization.lang("The given search ID was empty."));
} else if (result.isEmpty()) {
String fetcher = selectedItemProperty().getValue().getName();
String searchId = idText.getValue();
dialogService.showErrorDialogAndWait(Localization.lang("Fetcher '%0' did not find an entry for id '%1'.", fetcher, searchId));
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can I leave this error message or should it be unique?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, looks good so far

}
fetcherWorker = new FetcherWorker();

Expand Down
7 changes: 7 additions & 0 deletions src/main/java/org/jabref/logic/importer/fetcher/IsbnViaOttoBibFetcher.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,13 @@ public Optional<BibEntry> performSearchById(String identifier) throws FetcherExc
throw new FetcherException("Could not ", e);
}
Element textArea = html.select("textarea").first();

// inspect the "no results" error message (if there is one)
Optional<Element> potentialErrorMessageDiv = Optional.ofNullable((html.select("div#flash-notice.notice.add-bottom").first()));
if (potentialErrorMessageDiv.isPresent() && potentialErrorMessageDiv.get().text().contains("No Results")) {
LOGGER.error("ISBN {} not found at ottobib", identifier);
}

Optional<BibEntry> entry = Optional.empty();
try {
entry = BibtexParser.singleFromString(textArea.text(), importFormatPreferences, new DummyFileUpdateMonitor());
Expand Down