Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix could not connect to LO on Mac OSX #6970

Merged
merged 7 commits into from
Oct 3, 2020
Merged

Fix could not connect to LO on Mac OSX #6970

merged 7 commits into from
Oct 3, 2020

Conversation

Siedlerchr
Copy link
Member

@Siedlerchr Siedlerchr commented Oct 3, 2020 •
edited
Loading

Tested with LO 7. Apparently it's necessary to add the "real" soffice dir as well to the UrlClassLoader classpath

  • Change in CHANGELOG.md described (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked documentation: Is the information available and up to date? If not created an issue at https://github.com/JabRef/user-documentation/issues or, even better, submitted a pull request to the documentation repository.

@Siedlerchr Siedlerchr added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Oct 3, 2020
koppor
koppor requested changes Oct 3, 2020
View reviewed changes
Copy link
Member

@koppor koppor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nitpicks. Otherwise: LGTM

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
src/main/java/org/jabref/logic/openoffice/OpenOfficeFileSearch.java Show resolved Hide resolved
@Siedlerchr Siedlerchr merged commit e13fa8b into master Oct 3, 2020
@Siedlerchr Siedlerchr deleted the fixLOMac branch October 3, 2020 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koppor koppor koppor requested changes

Assignees
No one assigned
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Siedlerchr @koppor