Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix file update monitor shutdown #6835

Merged
merged 6 commits into from
Sep 2, 2020
Merged

Fix file update monitor shutdown #6835

merged 6 commits into from
Sep 2, 2020

Conversation

Siedlerchr
Copy link
Member

@Siedlerchr Siedlerchr commented Sep 1, 2020 •
edited
Loading

Follow up from #6118

Fixes #6559

Also fixes an error with the CoarseChangeFilter

I noticed that there is a problem with the FileupdateMonitor not shutting down correctly.
Now the File Watcher is closed.

  • Change in CHANGELOG.md described (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked documentation: Is the information available and up to date? If not created an issue at https://github.com/JabRef/user-documentation/issues or, even better, submitted a pull request to the documentation repository.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 1, 2020

The JabRef maintainers will add the following name to the AUTHORS file. In case you want to use a different one, please comment here and adjust your name in your git configuration for future commits.

m-mauersberger

@Siedlerchr Siedlerchr changed the title Fix file update monitor shutdown [wip]v Fix file update monitor shutdown Sep 1, 2020
@Siedlerchr
Merge remote-tracking branch 'upstream/master' into fixFileUpdateMoni…
e5d46cb 
…torShutdown

* upstream/master:
  Add connection check to NetworkTab in preferences (#6838)
  Refine IntelliJ howto to enable built-in compiler again (#6794)
  GitBook: [master] one page modified
  GitBook: [master] 3 pages and 3 assets modified
  Add missing }
  Refactor of remaining preference tabs to PreferencesService (#6836)
  ChipView for crossref and groups (#6228)
  Ignore codecov.io at external link check
  Fix linting issues
  Add "m-mauersberger"
  Update journalList.mv
@Siedlerchr
Exit watcher
18ac5c3
@Siedlerchr Siedlerchr changed the title [wip]v Fix file update monitor shutdown Fix file update monitor shutdown Sep 2, 2020
@github-actions
Copy link
Contributor

github-actions bot commented Sep 2, 2020

The JabRef maintainers will add the following name to the AUTHORS file. In case you want to use a different one, please comment here and adjust your name in your git configuration for future commits.

chenyuheng

@Siedlerchr Siedlerchr added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Sep 2, 2020
@calixtus calixtus merged commit 5c9edc9 into master Sep 2, 2020
@calixtus calixtus deleted the fixFileUpdateMonitorShutdown branch September 2, 2020 10:28
Siedlerchr added a commit that referenced this pull request Sep 2, 2020
@Siedlerchr
Merge remote-tracking branch 'upstream/master' into writebackupToTemp
a3adc38 
* upstream/master:
  Fix file update monitor shutdown (#6835)
  Typo: seperator --> separator (#6839)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobiasdiez tobiasdiez Awaiting requested review from tobiasdiez

Assignees
No one assigned
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

jabref does not shut down (on Linux); process keeps running
2 participants
@Siedlerchr @calixtus