Fix more fetchers #6790

koppor · 2020-08-24T22:31:49Z

This PR fixes fetchers (refs #6369):

Add cleanup for Library of Congress
SpringerLink now uses the SpringerNature API key (same key can be used) - refs Enable SpringerFetcherTest running on CI using a dedicated key #6729
Add URL logger for IEEE (and other fetchers)

Change in CHANGELOG.md described (if applicable)
Tests created for changes (if applicable)
Manually tested changed features in running JabRef (always required)
Screenshots added in PR description (for UI changes)
Checked documentation: Is the information available and up to date? If not created an issue at https://github.com/JabRef/user-documentation/issues or, even better, submitted a pull request to the documentation repository.

- Remove broken URL for title search - Switch to google.ch (maybe that's better?) - Add more LOGGER statements to Google Scho

…CSV field)

src/main/java/org/jabref/logic/importer/SearchBasedParserFetcher.java

Siedlerchr

extract the logger to a constant to be consistent with the rest of our code

src/main/java/org/jabref/logic/importer/SearchBasedParserFetcher.java

...java/org/jabref/logic/importer/fetcher/CollectionOfComputerScienceBibliographiesFetcher.java

src/main/java/org/jabref/logic/importer/fetcher/GoogleScholar.java

.../org/jabref/logic/importer/fetcher/CollectionOfComputerScienceBibliographiesFetcherTest.java

src/test/java/org/jabref/logic/importer/fetcher/SpringerFetcherTest.java

src/main/java/org/jabref/logic/importer/SearchBasedParserFetcher.java

koppor added 7 commits August 24, 2020 23:02

Refine Google Scholar

96349de

- Remove broken URL for title search - Switch to google.ch (maybe that's better?) - Add more LOGGER statements to Google Scho

Fix the bad data of MODS

4207ada

Add failed URL to logger

6a5dfdc

Log used URL

f69f782

Refine comment

cab731d

Disable the test for a non-working capability

e1ff139

SpringerLink also uses Springer API key

fe47134

koppor added this to the v5.1 milestone Aug 24, 2020

koppor added 4 commits August 25, 2020 06:12

Fix checkstyle

b5a1026

Identifiers in CCSB are now put as key/value fields (instead of flat …

ddf6346

…CSV field)

Fix checkstyle

4306332

Adapt CiteSeerTest to new CiteSeer capabilities

770a6c2

Siedlerchr reviewed Aug 25, 2020

View reviewed changes

src/main/java/org/jabref/logic/importer/SearchBasedParserFetcher.java Outdated Show resolved Hide resolved

Siedlerchr requested changes Aug 25, 2020

View reviewed changes

Siedlerchr approved these changes Aug 25, 2020

View reviewed changes

tobiasdiez requested changes Aug 25, 2020

View reviewed changes

koppor added 7 commits August 25, 2020 20:23

Address commetn ins SearchBasedParserFetcher

404251a

Address CCSB issues

43e022f

Adress Google Scholar Fetcher comments

bb2eb1c

Final fixes

214d007

Merge remote-tracking branch 'origin/master' into fix-fetchers

ad9eb48

Keep structure, but include URL in exception

f5cc4dd

Fix copy'n'paste error

776220d

tobiasdiez reviewed Aug 25, 2020

View reviewed changes

src/main/java/org/jabref/logic/importer/SearchBasedParserFetcher.java Outdated Show resolved Hide resolved

koppor added 4 commits August 26, 2020 13:08

Add ADR on logging

a90e21a

Add forgotten code (and another "Bad, because" statement)

faeb0d5

Fix code

bf77fd3

Finalize SearchbasedParserFetcher

bbc994a

koppor merged commit d052170 into master Aug 26, 2020

koppor deleted the fix-fetchers branch August 26, 2020 20:03

koppor mentioned this pull request Aug 26, 2020

Reiteratate on URL showing on SearchBasedParserFetcher JabRef/jabref-koppor#467

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix more fetchers #6790

Fix more fetchers #6790

koppor commented Aug 24, 2020

Siedlerchr left a comment

Fix more fetchers #6790

Fix more fetchers #6790

Conversation

koppor commented Aug 24, 2020

Siedlerchr left a comment

Choose a reason for hiding this comment