-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shared database synchronized by FocusChangedEvent #6771
Merged
Merged
Changes from 2 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
87adec3
Added FocusChangedEvent, fired in BibEntry when setFocusedField is ca…
0c895c1
Uncomment FieldChangedEvent listener.
c53ed56
Removed FocusChangedEvent.java due to improper dependencies.
m-mauersberger 079f913
Delete FocusChangedEvent.java
m-mauersberger a680ecb
Update EntryEditor.java
tobiasdiez 346d85a
Update CoarseChangeFilter.java
tobiasdiez 2fb31f7
Update CoarseChangeFilter.java
tobiasdiez b76e7f2
Update CoarseChangeFilter.java
tobiasdiez File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -31,8 +31,10 @@ public synchronized void listen(@SuppressWarnings("unused") BibDatabaseContextCh | |
// Only relay event if the field changes are more than one character or a new field is edited | ||
FieldChangedEvent fieldChange = (FieldChangedEvent) event; | ||
boolean isEditOnNewField = lastFieldChanged == null || !lastFieldChanged.equals(fieldChange.getField()); | ||
// Only deltas of 1 registered by fieldChange | ||
boolean isMajorChange = fieldChange.getDelta() >= 1; | ||
|
||
if (fieldChange.getDelta() > 1 || isEditOnNewField) { | ||
if (isEditOnNewField) { | ||
lastFieldChanged = fieldChange.getField(); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. See the eventBus.post method, the eventBus post method is reposinsible for firing the event. |
||
eventBus.post(event); | ||
} | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
37 changes: 37 additions & 0 deletions
37
src/main/java/org/jabref/model/entry/event/FocusChangedEvent.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,37 @@ | ||
package org.jabref.model.entry.event; | ||
|
||
import org.jabref.model.entry.BibEntry; | ||
import org.jabref.model.entry.field.Field; | ||
|
||
/** | ||
* <code>FocusChangedEvent</code> is fired when the focus of a field of <code>BibEntry</code> has been requested. | ||
*/ | ||
|
||
public class FocusChangedEvent extends EntryChangedEvent { | ||
|
||
private final Field field; | ||
|
||
/** | ||
* @param bibEntry Affected BibEntry object | ||
* @param field Name of field which focus has been requested | ||
* @param location location Location affected by this event | ||
*/ | ||
public FocusChangedEvent(BibEntry bibEntry, Field field, EntriesEventSource location) { | ||
super(bibEntry, location); | ||
this.field = field; | ||
} | ||
|
||
/** | ||
* @param bibEntry Affected BibEntry object | ||
* @param field Name of field which focus has been requested | ||
*/ | ||
public FocusChangedEvent(BibEntry bibEntry, Field field) { | ||
super(bibEntry); | ||
this.field = field; | ||
} | ||
|
||
public Field getField() { | ||
return field; | ||
} | ||
|
||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the problem is that you are listening to an Event from the EventBus which is nowhere fired