Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve handling of annotation processor in eclipse #6749

Merged
merged 2 commits into from
Aug 11, 2020

Conversation

tobiasdiez
Copy link
Member

I played around a bit with JabRef in VS Code, and encountered a problem with the annotation processing. It was quite easy to fix by putting the files generated by the annotation processor in the src/gen folder.

Since VS Code uses the same libraries as eclipse under the hood, this fix should also apply to eclipse directly. @Siedlerchr can you please confirm. Thanks!

Background infos: http://dplatz.de/blog/2018/gradle-apt.html

@tobiasdiez tobiasdiez requested a review from Siedlerchr August 9, 2020 16:20
@tobiasdiez tobiasdiez added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Aug 9, 2020
* upstream/master: (47 commits)
  Fix copy pasting and delete via menu or key (#6740)
  Add instructions how to work with fetchers  (#6731)
  Autoinstall extension in chrome (#6442)
  Delete link after download (#6723)
  New translations JabRef_en.properties (Portuguese, Brazilian) (#6728)
  Bump pascalgn/automerge-action from v0.8.5 to v0.9.0 (#6736)
  Bump byte-buddy-parent from 1.10.13 to 1.10.14 (#6733)
  Bump mockito-core from 3.4.4 to 3.4.6 (#6734)
  Bump unirest-java from 3.8.06 to 3.9.00 (#6735)
  Bump org.beryx.jlink from 2.21.1 to 2.21.2 (#6732)
  Add testing interface, including a set of capabilities to tests for (#6687)
  Fix pasting on mac and linux (#6419)
  Add validation of "AUTHORS" file (#6722)
  Squashed 'src/main/resources/csl-styles/' changes from cacc4ee..827b986
  New Crowdin updates (#6721)
  Add missing AUTHORs
  Fix for issue 6639 (#6719)
  Fix more links
  Fix link
  New Crowdin updates (#6718)
  ...
@Siedlerchr
Copy link
Member

Siedlerchr commented Aug 9, 2020

Unfortunately it did not work on my windows machine
I ran ./gradlew eclipse

@tobiasdiez
Copy link
Member Author

Does the Log4jPlugins.java exist in src/main/gen ? Are there error messages?

@Siedlerchr
Copy link
Member

I tried again. I executed gradlew run first. Then I can run it in Eclipse as well. Maybe the processResources command needs to be executed for the eclipse command as well.

@Siedlerchr Siedlerchr merged commit 7ddfd9c into master Aug 11, 2020
@Siedlerchr Siedlerchr deleted the annotationProcessor branch August 11, 2020 12:28
Siedlerchr added a commit that referenced this pull request Aug 14, 2020
* upstream/master:
  Improve handling of annotation processor in eclipse (#6749)
  New Crowdin updates (#6741)
  Bump appleboy/ssh-action from v0.1.2 to v0.1.3 (#6752)
  Bump WyriHaximus/github-action-wait-for-status from 0.1.0 to v1.1 (#6751)
  Squashed 'src/main/resources/csl-styles/' changes from 827b986..d23a3ab
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants