Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable SpringerFetcherTest running on CI using a dedicated key #6729

Merged
merged 3 commits into from
Aug 23, 2020
Merged

Enable SpringerFetcherTest running on CI using a dedicated key #6729

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fce318e
Enable SpringerFetcherTest running on CI using a dedicated key
koppor Aug 2, 2020
a3e209a
Add more CI/CD keys
koppor Aug 4, 2020
349ea0d
Merge branch 'master' into enable-springer-tests
koppor Aug 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/tests-fetchers.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ on:
- cron: '2 3 * * 3'

env:
SpringerNatureAPIKey: ${{ secrets.SpringerNatureAPIKey }}
SpringerNatureAPIKey: ${{ secrets.SPRINGERNATUREAPIKEY_FOR_TESTS }}
AstrophysicsDataSystemAPIKey: ${{ secrets.AstrophysicsDataSystemAPIKey }}
IEEEAPIKey: ${{ secrets.IEEEAPIKey }}

Expand Down
4 changes: 0 additions & 4 deletions src/test/java/org/jabref/logic/importer/fetcher/SpringerFetcherTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
import org.jabref.model.entry.BibEntry;
import org.jabref.model.entry.field.StandardField;
import org.jabref.model.entry.types.StandardEntryType;
import org.jabref.support.DisabledOnCIServer;
import org.jabref.testutils.category.FetcherTest;

import kong.unirest.json.JSONObject;
Expand All @@ -26,7 +25,6 @@ void setUp() {
fetcher = new SpringerFetcher();
}

@DisabledOnCIServer("Disable on CI Server to not hit the API call limit")
@Test
void searchByQueryFindsEntry() throws Exception {
BibEntry expected = new BibEntry(StandardEntryType.Article);
Expand All @@ -49,7 +47,6 @@ void searchByQueryFindsEntry() throws Exception {
assertEquals(Collections.singletonList(expected), fetchedEntries);
}

@DisabledOnCIServer("Disable on CI Server to not hit the API call limit")
@Test
void testSpringerJSONToBibtex() {
String jsonString = "{\r\n" + " \"identifier\":\"doi:10.1007/BF01201962\",\r\n"
Expand All @@ -73,7 +70,6 @@ void testSpringerJSONToBibtex() {
assertEquals(Optional.of("1992-09-01"), bibEntry.getField(StandardField.DATE));
}

@DisabledOnCIServer("Disable on CI Server to not hit the API call limit")
@Test
void searchByEmptyQueryFindsNothing() throws Exception {
assertEquals(Collections.emptyList(), fetcher.performSearch(""));
Expand Down