Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some fetcher tests #6587

Merged
merged 11 commits into from
Jun 12, 2020
Merged

Fix some fetcher tests #6587

merged 11 commits into from
Jun 12, 2020

Conversation

calixtus
Copy link
Member

@calixtus calixtus commented Jun 5, 2020

refs #6369

  • Change in CHANGELOG.md described (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked documentation: Is the information available and up to date? If not created an issue at https://github.com/JabRef/user-documentation/issues or, even better, submitted a pull request to the documentation repository.

@Siedlerchr
Copy link
Member

I think the INSPIRE test can also be fixed, seems like the bib item changed

@calixtus
Copy link
Member Author

calixtus commented Jun 7, 2020

The INSPIRE test leaves me clueless. The text is exactly the same. Maybe it's about the line seperators? I was unable to debug the test myself. Can you maybe take a look at it, @Siedlerchr ?

@Siedlerchr
Copy link
Member

Siedlerchr commented Jun 7, 2020

For inspire change the line in the second entry to this:
article.setField(StandardField.JOURNAL, "Nucl. Phys. B");
without the double back slashes

@Siedlerchr Siedlerchr mentioned this pull request Jun 7, 2020
1 task
@calixtus
Copy link
Member Author

calixtus commented Jun 8, 2020

@Siedlerchr and @tobiasdiez , could you do me a favor and take a look on the buildinfo stuff, i'm not sure if I did that right and i'm unable to debug that. According to the test log, instead of the api key the IEEE fetcher only recieves three asterisks from the build script. Is this normal? Did I do something wrong?

@koppor
Copy link
Member

koppor commented Jun 9, 2020

The test log does not output the API keys, it just outputs starts. This is perfectly OK.

@calixtus
Copy link
Member Author

This PR is done for now and should fix all the fetcher tests, except IEEE fetcher, which depends most likely on a new api key.

@calixtus calixtus added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Jun 12, 2020
@Siedlerchr
Copy link
Member

So we now only have MrDlib and IEEE not working

@calixtus
Copy link
Member Author

calixtus commented Jun 12, 2020

Strange, MrDlib tests ran through an hour ago without complaining...

@calixtus calixtus changed the title Fix some broken links in fetcher tests Fix some fetcher tests Jun 12, 2020
@Siedlerchr Siedlerchr merged commit 7d8b81d into master Jun 12, 2020
@Siedlerchr Siedlerchr deleted the fix_broken_links_in_fetcher_test branch June 12, 2020 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants