Add truncate as a BibTex key modifier

CHANGELOG.md

@@ -18,6 +18,7 @@ Note that this project **does not** adhere to [Semantic Versioning](http://semve
 - We now show the number of items found and selected to import in the online search dialog. [#6248](https://github.com/JabRef/jabref/pull/6248)
 - We created a new install screen for macOS. [#5759](https://github.com/JabRef/jabref/issues/5759)
 - We implemented an option to download fulltext files while importing. [#6381](https://github.com/JabRef/jabref/pull/6381)
+- We added a BibTex key modifier for truncating strings. [#3915](https://github.com/JabRef/jabref/issues/3915)
 
 ### Changed
 
@@ -50,6 +51,7 @@ Note that this project **does not** adhere to [Semantic Versioning](http://semve
 - We fixed an issue where JabRef switched to discrete graphics under macOS [#5935](https://github.com/JabRef/jabref/issues/5935)
 - We fixed an issue where the Preferences entry preview will be unexpected modified leads to Value too long exception [#6198](https://github.com/JabRef/jabref/issues/6198)
 - We fixed an issue where custom jstyles for Open/LibreOffice would only be valid if a layout line for the entry type `default` was at the end of the layout section [#6303](https://github.com/JabRef/jabref/issues/6303)
+- We fixed an issue where long directory names created from patterns could create an exception. [#3915](https://github.com/JabRef/jabref/issues/3915)
 
 ### Removed
 

src/main/java/org/jabref/logic/formatter/Formatters.java

@@ -29,6 +29,7 @@
 import org.jabref.logic.formatter.casechanger.TitleCaseFormatter;
 import org.jabref.logic.formatter.casechanger.UpperCaseFormatter;
 import org.jabref.logic.formatter.minifier.MinifyNameListFormatter;
+import org.jabref.logic.formatter.minifier.TruncateFormatter;
 import org.jabref.logic.layout.format.LatexToUnicodeFormatter;
 import org.jabref.model.cleanup.Formatter;
 
@@ -102,6 +103,9 @@ public static Optional<Formatter> getFormatterForModifier(String modifier) {
         if (modifier.startsWith(RegexFormatter.KEY)) {
             String regex = modifier.substring(RegexFormatter.KEY.length());
             return Optional.of(new RegexFormatter(regex));
+        } else if (modifier.matches("\\Atruncate\\d+\\z")) {
+            int truncateAfter = Integer.parseInt(modifier.substring(8));
+            return Optional.of(new TruncateFormatter(truncateAfter));
         } else {
             return getAll().stream().filter(f -> f.getKey().equals(modifier)).findAny();
         }

src/main/java/org/jabref/logic/formatter/minifier/TruncateFormatter.java

@@ -0,0 +1,51 @@
+package org.jabref.logic.formatter.minifier;
+
+import java.util.Objects;
+
+import org.jabref.logic.l10n.Localization;
+import org.jabref.model.cleanup.Formatter;
+
+public class TruncateFormatter extends Formatter {
+    private final int TRUNCATE_AFTER;
+    private final String KEY;
+
+    /**
+     * The TruncateFormatter truncates a string after the given index and removes trailing whitespaces.
+     *
+     * @param truncateIndex truncate a string after this index.
+     */
+    public TruncateFormatter(final int truncateIndex) {
+        TRUNCATE_AFTER = truncateIndex;
+        KEY = "truncate" + TRUNCATE_AFTER;
+    }
+
+    @Override
+    public String getName() {
+        return Localization.lang("Truncate");
+    }
+
+    @Override
+    public String getKey() {
+        return KEY;
+    }
+
+    /**
+     * Truncates a string after the given index.
+     */
+    @Override
+    public String format(final String input) {
+        Objects.requireNonNull(input);
+        final int index = Math.min(TRUNCATE_AFTER, input.length());
+        return input.substring(0, index).stripTrailing();
+    }
+
+    @Override
+    public String getDescription() {
+        return Localization.lang("Truncates a string after a given index.");
+    }
+
+    @Override
+    public String getExampleInput() {
+        return "Truncate this sentence.";
+    }
+}

src/main/java/org/jabref/logic/util/io/FileUtil.java

@@ -272,22 +272,27 @@ public static String createFileNameFromPattern(BibDatabase database, BibEntry en
     }
 
     /**
-     * Determines filename provided by an entry in a database
+     * Determines directory name provided by an entry in a database
      *
      * @param database        the database, where the entry is located
-     * @param entry           the entry to which the file should be linked to
-     * @param fileNamePattern the filename pattern
-     * @return a suggested fileName
+     * @param entry           the entry to which the directory should be linked to
+     * @param directoryNamePattern the dirname pattern
+     * @return a suggested dirName
      */
-    public static String createDirNameFromPattern(BibDatabase database, BibEntry entry, String fileNamePattern) {
-        String targetName = BracketedPattern.expandBrackets(fileNamePattern, ';', entry, database);
+    public static String createDirNameFromPattern(BibDatabase database, BibEntry entry, String directoryNamePattern) {
+        String targetName = BracketedPattern.expandBrackets(directoryNamePattern, ';', entry, database);
 
         if (targetName.isEmpty()) {
             targetName = entry.getCiteKeyOptional().orElse("default");
         }
 
-        // Removes illegal characters from filename
+        // Removes illegal characters from directory name
         targetName = FileNameCleaner.cleanDirectoryName(targetName);
+
+        // Only use valid filenames for the directories in the path
+        targetName = Arrays.stream(targetName.split(Pattern.quote(File.separator)))
+                            .map(FileUtil::getValidFileName)
+                            .collect(Collectors.joining(File.separator));
         return targetName;
     }
 

src/main/resources/l10n/JabRef_en.properties

@@ -2233,3 +2233,5 @@ Computer\ software.\ The\ standard\ styles\ will\ treat\ this\ entry\ type\ as\
 A\ data\ set\ or\ a\ similar\ collection\ of\ (mostly)\ raw\ data.=A data set or a similar collection of (mostly) raw data.
 
 Display\ count\ of\ items\ in\ group=Display count of items in group
+Truncate=Truncate
+Truncates\ a\ string\ after\ a\ given\ index.=Truncates a string after a given index.

src/test/java/org/jabref/logic/util/BracketedPatternTest.java → src/test/java/org/jabref/logic/bibtexkeypattern/BracketedPatternTest.java

@@ -1,6 +1,5 @@
-package org.jabref.logic.util;
+package org.jabref.logic.bibtexkeypattern;
 
-import org.jabref.logic.bibtexkeypattern.BracketedPattern;
 import org.jabref.model.database.BibDatabase;
 import org.jabref.model.entry.BibEntry;
 import org.jabref.model.entry.BibtexString;
@@ -241,4 +240,19 @@ void regularExpressionReplace() {
         assertEquals("2003-JabRef Science",
                 BracketedPattern.expandBrackets("[year]-[journal:regex(\"Organization\",\"JabRef\")]", ';', dbentry, database));
     }
+
+    /**
+     * Test the [:truncate] modifier
+     */
+    @Test
+    void truncateModifiersWorksAppliedTwice() {
+        assertEquals("Open",
+                BracketedPattern.expandBrackets("[fulltitle:truncate6:truncate5]", ';', dbentry, database));
+    }
+
+    @Test
+    void truncateModifierIsIgnoredWithoutAnArgument() {
+        assertEquals("Open Source Software and the \"Private-Collective\" Innovation Model: Issues for Organization Science",
+                BracketedPattern.expandBrackets("[fulltitle:truncate]", ';', dbentry, database));
+    }
 }

src/test/java/org/jabref/logic/formatter/minifier/TruncateFormatterTest.java

@@ -0,0 +1,36 @@
+package org.jabref.logic.formatter.minifier;
+
+import org.junit.jupiter.api.Test;
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+
+/**
+ * Tests in addition to the general tests from {@link org.jabref.logic.formatter.FormatterTest}
+ */
+public class TruncateFormatterTest {
+    private final String TITLE = "A Title";
+
+    @Test
+    void truncateModifierWorksWith0Length() {
+        TruncateFormatter formatter = new TruncateFormatter(0);
+        assertEquals("", formatter.format(TITLE));
+    }
+
+    @Test
+    void truncateModifierRemovesTrailingWhitespace() {
+        TruncateFormatter formatter = new TruncateFormatter(2);
+        assertEquals("A", formatter.format(TITLE));
+    }
+
+    @Test
+    void truncateModifierKeepsInternalWhitespace() {
+        TruncateFormatter formatter = new TruncateFormatter(3);
+        assertEquals("A T", formatter.format(TITLE));
+    }
+
+    @Test
+    void truncateModifierWorksWith9999Length() {
+        TruncateFormatter formatter = new TruncateFormatter(9999);
+        assertEquals(TITLE, formatter.format(TITLE));
+    }
+}