Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep group pane size when resizing window (#6180) #6423

Merged
merged 3 commits into from
May 16, 2020
Merged

Keep group pane size when resizing window (#6180) #6423

merged 3 commits into from
May 16, 2020

Conversation

Hollyqqqqq
Copy link
Contributor

@Hollyqqqqq Hollyqqqqq commented May 5, 2020 •
edited
Loading

Fixes #6180

Hello, I think I have fixed this bug. The main reason for this bug is group pane is resizable with parent(window size). I add one line in JabRefFrame.java to set group pane not resizable with parent. Thus it can keep size when resizing window. The following is manual test:

Before resizing window:
image

After resizing window:
image

  • Change in CHANGELOG.md described (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked documentation: Is the information available and up to date? If not created an issue at https://github.com/JabRef/user-documentation/issues or, even better, submitted a pull request to the documentation repository.

Siedlerchr
Siedlerchr approved these changes May 6, 2020
View reviewed changes
Copy link
Member

@Siedlerchr Siedlerchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me! Indeed, it does not make sense to put them together

@Hollyqqqqq
Copy link
Contributor Author

Thanks! But I don't understand what is the meaning of "it does not make sense to put them together". Put what together?

In fact, keeping group size when resizing window is similar to project pane of IntelliJ IDEA. In IDEA, project pane keeps size when resizing window. If it doesn't keep size, the following behavior will occur:
image
Since group pane only need to display group tree, it doesn't need too much space when resizing window and we need to resize group pane manully if this happens. Thus I think keeping size when resizing window has its utility.

What's more, in IDEA, it has scroll bar for project pane if the window size is too small.
image

I think this behavior can also be involved in JabRef. If this point can be agreed, I'd like to create a new issue about this and work for it.

@Siedlerchr
Copy link
Member

@Hollyqqqqq

Thanks! But I don't understand what is the meaning of "it does not make sense to put them together". Put what together?

Sorry for the misunderstanding, I was meaning that you are right, a separation of the group reisze and the parent window resize is better.
You could also try to add the scrollbars in your PR as well or create a new one.

@Hollyqqqqq
Copy link
Contributor Author

OK, I see. Thank you very much!

@Siedlerchr Siedlerchr marked this pull request as ready for review May 12, 2020 09:14
@Siedlerchr Siedlerchr added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label May 12, 2020
tobiasdiez
tobiasdiez approved these changes May 13, 2020
View reviewed changes
Copy link
Member

@tobiasdiez tobiasdiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! The change looks good to me. Just to clarify and since the javadoc of the setResizableWithParent method wasn't clear on this, you can still resize the sidepane manually, right?

Can you please add a changelog entry, then we can merge!

@Hollyqqqqq
Copy link
Contributor Author

Yes, user can still resize the sidepane manually. And I have added the change log in CHANGELOG.md.

@tobiasdiez tobiasdiez merged commit cb50b50 into JabRef:master May 16, 2020
Siedlerchr added a commit that referenced this pull request May 16, 2020
@Siedlerchr
Merge remote-tracking branch 'upstream/master' into udpate-gradle-to-64
8cd69cc 
* upstream/master: (50 commits)
  Keep group pane size when resizing window (#6180) (#6423)
  Changelog: Fix missing citation for biblatex-mla
  Update AUTHORS
  Check duplicate DOI (#6333)
  Fix missing citation for biblatex-mla
  Change EasyBind dependency (#6480)
  Add testing of latest dev version as mandatory
  Squashed 'src/main/resources/csl-styles/' changes from 5dad23d..586e0b8
  Fix libre office connection and other progress dialogs (#6478)
  Fix clear year and month field when converting to biblatex (#6434)
  Add truncate as a BibTex key modifier (#6427)
  Add new authors (not all - they need more work)
  Remove empty line
  Add simple Unit Tests for #6207 (#6240)
  Enforce LeftCurly rule (#6452)
  Implement task progress indicator (and dialog) in the toolbar (#6443)
  Consider empty brackets
  Changelog update
  Added a test
  Fixed brackets in regular expressions
  ...
Siedlerchr added a commit that referenced this pull request Jul 1, 2020
@Siedlerchr
Merge remote-tracking branch 'upstream/master' into allowReordering
791f458 
# By dependabot-preview[bot] (18) and others
# Via GitHub (17) and others
* upstream/master: (77 commits)
  Reenable caching of gradle
  Refactor BibtexKeyPatternPreferences (#6489)
  Update CHANGELOG.md
  Add changelog entry and remove unnecessary code
  EasyBind revision part two
  Fix Drag and Drop on empty database
  Truncates DOIs and URLs in the column "Linked identifiers" in main table, if too long (#6498)
  Bump flexmark-ext-gfm-tasklist from 0.61.26 to 0.61.30
  Bump flexmark from 0.61.26 to 0.61.30
  Bump xmlunit-matchers from 2.6.4 to 2.7.0
  Bump java-string-similarity from 1.2.1 to 2.0.0
  Bump flexmark-ext-gfm-strikethrough from 0.61.26 to 0.61.30
  Bump xmlunit-core from 2.6.4 to 2.7.0
  Truncates the link and/or the link description in the column "linked files" in main table, if too long (#6179)
  Keep group pane size when resizing window (#6180) (#6423)
  Changelog: Fix missing citation for biblatex-mla
  Update AUTHORS
  Check duplicate DOI (#6333)
  Fix missing citation for biblatex-mla
  Change EasyBind dependency (#6480)
  ...

# Conflicts:
#	src/main/java/org/jabref/gui/actions/ActionHelper.java
#	src/main/java/org/jabref/gui/customentrytypes/CustomEntryTypeDialogViewModel.java
#	src/main/java/org/jabref/gui/customentrytypes/CustomizeEntryTypeDialogView.java
#	src/main/java/org/jabref/model/entry/field/FieldFactory.java
koppor pushed a commit that referenced this pull request Mar 1, 2023
Squashed 'buildres/csl/csl-styles/' changes from 9926b48cf3..e9fd2027de
6bf852c 
e9fd2027de Add Medicine Publishing Styles (#6434)
cae128f35f Create Bristol University Press (#6356)
74b4af3b82 Create internet-archaeology.csl (#6357)
ee7ece480b Add Bio-Protocol style (#6429)
9a455efcee Create archives-of-medical-research.csl (#6415)
e91aba46fc Remove some bursa-uludag styles (#6423)
03f3962657 Update offa.csl (#6428)
95dc9b9f5a Update journal-of-neolithic-archaeology.csl (#6427)
a4e6c7f477 Update the-university-of-winchester-harvard.csl (#6374)
c0bf10647a add manuscript formatting to ASA (#6387)
3a673a564a Update universite-de-sherbrooke-histoire.csl (#6392)
0c48c7289e Update chemistry-education-research-and-practice.csl (#6397)
51f718a7b9 Update journal-of-endodontics.csl (#6409)
51e419051f Update presses-universitaires-de-rennes.csl (#6413)

git-subtree-dir: buildres/csl/csl-styles
git-subtree-split: e9fd2027de4e2355f3244ac662960467e225774d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobiasdiez tobiasdiez tobiasdiez approved these changes

@Siedlerchr Siedlerchr Siedlerchr approved these changes

Assignees
No one assigned
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Groups panel does not keep size when resizing window
3 participants
@Hollyqqqqq @Siedlerchr @tobiasdiez