Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correcting file name for groups.uml #6373

Merged
merged 2 commits into from
May 1, 2020
Merged

Correcting file name for groups.uml #6373

merged 2 commits into from
May 1, 2020

Conversation

mlep
Copy link
Contributor

@mlep mlep commented Apr 29, 2020

@Siedlerchr
Copy link
Member

@mlep Thanks for updating. The links with tree... are always refering to a specific commit in time. In most cases it makes sense to refer to a specific version as later versions might have change it.
And I think when you paste a link to tree/master it sometimes get replaced with the commit speciciv version automatically.
But for the documentation it's not necessary

docs/README.md Outdated Show resolved Hide resolved
@mlep
Copy link
Contributor Author

mlep commented Apr 29, 2020

@Siedlerchr thank you for the explanation. I have now simplified all the links with tree/ .
@koppor I have integrated a shorter link, as you suggested.
Additionnally, I have updated the section about Decision records.

Copy link
Member

@tobiasdiez tobiasdiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tobiasdiez tobiasdiez merged commit 34cafeb into JabRef:master May 1, 2020
@mlep mlep deleted the patch-1 branch May 2, 2020 07:25
Siedlerchr added a commit that referenced this pull request May 2, 2020
* upstream/master: (166 commits)
  New Crowdin translations (#6382)
  Update code-howtos.md (#6393)
  Fix jstyle was invalid with default section at the start (#6386)
  Correcting file name for groups.uml (#6373)
  Fix underscore character being omitted from file name in Recent Libraries list (#6389)
  Rework journal abbreviation caching (#6304)
  Fix selecting custom export for copy to clipboard with uppercase file ext (#6290)
  New Crowdin translations (#6375)
  Squashed 'src/main/resources/csl-styles/' changes from 143464e..906cd6d
  Fixes #6357: File directory (#6377)
  Disable the generate button if the ID field is empty (#6371)
  Fix Preferences style value too long (#6372)
  Fix various Dark theme issues (#6368)
  Correct label name in dependabot
  Bump java-diff-utils from 4.5 to 4.7 (#6365)
  Try with info.plist.template also (#6366)
  Fix wrong button order (Apply and Cancel) in ManageProtectedTermsDialog. (#6358)
  Bump flexmark-ext-gfm-strikethrough from 0.61.6 to 0.61.20 (#6361)
  Bump checkstyle from 8.31 to 8.32 (#6360)
  Bump flexmark-ext-gfm-tasklist from 0.61.16 to 0.61.20 (#6364)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants