Make wrap fields also visible in entry editor #6315

Siedlerchr · 2020-04-19T17:53:25Z

I simple reused the FieldFormatterPreferences wrapFieldList. More like a hack.
The original multiline property got removed in #5230
A more elegant solution would be to maybe add this to the custom entry types dialog?

Change in CHANGELOG.md described (if applicable)
Tests created for changes (if applicable)
Manually tested changed features in running JabRef (always required)
Screenshots added in PR description (for UI changes)
Checked documentation: Is the information available and up to date? If not created an issue at https://github.com/JabRef/user-documentation/issues or, even better, submitted a pull request to the documentation repository.

Fixes #4373

tobiasdiez

It's indeed a bit hacky. I like your idea to make this configurable since this is only one instance where people add a new field and require a certain type of action (e.g. what if I add a new "persons" field, or a new "keywords" field?). Thus having an option to specify the type of a field would be good.

src/main/java/org/jabref/model/entry/field/FieldFactory.java

src/main/java/org/jabref/preferences/JabRefPreferences.java

@ayaankazerouni

* upstream/master: Update label names Squashed 'src/main/resources/csl-locales/' changes from d0ee4d13c9..79845b087b Squashed 'src/main/resources/csl-styles/' changes from c1793d2..143464e Cite work by @ayaankazerouni Improve performance for loading files (#6332) Add ADR von JUnit vs. AssertJ (#6335) 'Name' textfield on focus instead of 'OK' button when user clicks on 'Add subgroup' option (#6330) Bump jurt from 6.3.2 to 6.4.3 (#6325) Bump unoil from 6.3.2 to 6.4.3 (#6320) Bump ridl from 6.3.2 to 6.4.3 (#6326) Bump classgraph from 4.8.69 to 4.8.71 (#6322) Bump flexmark from 0.61.6 to 0.61.16 (#6318) Bump richtextfx from 0.10.4 to 0.10.5 (#6319) Bump guava from 28.2-jre to 29.0-jre (#6323) Bump flexmark-ext-gfm-tasklist from 0.61.6 to 0.61.16 (#6327) Bump org.beryx.jlink from 2.17.5 to 2.17.7 (#6324) Improve performance massively by fixing a stupid binding mistake (#6316) Fixed missing paste command (#6313) Remove cache of auto completion results (#6310)

Siedlerchr · 2020-04-24T17:22:11Z

I would leave a proper implementation for the future. This depends also a bit on #6152

koppor

Since this fixes an issue, we really need a CHANGELOG.md entry.

koppor · 2020-04-26T20:11:08Z

src/main/java/org/jabref/gui/fieldeditors/FieldEditors.java

@@ -52,10 +51,10 @@ public static FieldEditorFX getForField(final Field field,
                preferences.getBoolean(JabRefPreferences.ENFORCE_LEGAL_BIBTEX_KEY),
                preferences.getBoolean(JabRefPreferences.ALLOW_INTEGER_EDITION_BIBTEX));

-        final boolean isSingleLine = FieldFactory.isSingleLineField(field);
+         boolean isMultiLine = FieldFactory.isMultiLineField(field, preferences.getFieldContentParserPreferences().getNonWrappableFields());


Can we use an enum here? I really don't like the booleans - and we see changing the flag from singleLine to multiLine was necessary of readability. (Otherweise, the variable would be kept to flag singleLine - and negation would be used)

I propose to use a boolean enum as proposed at https://stackoverflow.com/a/12713550/873282

enum USED_LINES { MULTI(true), SINGLE(false); ...

Maybe, just a simple enum would also be OK. Then, the construction from boolean would be a bit more tricky though.

If you want to go in this direction, an enum FieldType with Text and TextLong would make the most sense and conveys the semantics. Can then be extended in the future to include Keywords, Numeric etc.

I really would like to leave it for the moment and implement a more generic solution in a follow up PR. I think about integrating it in the custom entry types dialog.

koppor · 2020-04-26T20:11:50Z

src/main/java/org/jabref/gui/fieldeditors/PersonsEditor.java

-        textInput = isSingleLine
-                ? new EditorTextField()
-                : new EditorTextArea();
+        textInput = isMultiLine ? new EditorTextArea() : new EditorTextField();


Not that the true/false branches were just be wrapped. Another indicator for an enum!

* upstream/master: Backward compatibility for 4.3.1 (#6296) Fix Export to clipboard Dialog icon (#6345) Refactor EntryEditorPreferences (#6245)

calixtus · 2020-05-08T15:57:31Z

Ping.
How do we proceed here?

Siedlerchr · 2020-05-08T18:07:29Z

I m merge this now and will work on a more clean solution

…ptyLib * upstream/master: (23 commits) Make wrap fields also visible in entry editor (#6315) Add launcher to fix extension import in snap (#6439) add concise message when SaveException happen (#6444) Squashed 'src/main/resources/csl-locales/' changes from 79845b087b..cbb45961b8 Squashed 'src/main/resources/csl-styles/' changes from 906cd6d..270cd32 Addition to the early pull #6438 (#6441) Fix the bug #6421 (#6438) Cleanup dead code (#6436) Fixed entry duplication on file download (#6437) Add workaround for buildSrc issue (#6433) Remove dash from illegal characters. (#6300) Docs: For developers: New architectural decision added to list (#6397) Added a download checkbox to the import dialog (#6381) Bump jaxb-xjc from 2.3.2 to 2.3.3 (#6410) Bump flexmark-ext-gfm-strikethrough from 0.61.20 to 0.61.24 (#6413) Bump byte-buddy-parent from 1.10.9 to 1.10.10 (#6408) Bump flexmark-ext-gfm-tasklist from 0.61.20 to 0.61.24 (#6412) Bump org.beryx.jlink from 2.17.8 to 2.18.0 (#6411) Bump tika-core from 1.24 to 1.24.1 (#6409) Bump flexmark from 0.61.20 to 0.61.24 (#6416) ...

* upstream/master: Make wrap fields also visible in entry editor (#6315) Add launcher to fix extension import in snap (#6439) add concise message when SaveException happen (#6444)

Make wrap fields also visible in entry editor

0b39116

Fixes #4373

Siedlerchr force-pushed the multiline branch from ee680f7 to 0b39116 Compare April 19, 2020 17:57

tobiasdiez requested changes Apr 19, 2020

View reviewed changes

src/main/java/org/jabref/model/entry/field/FieldFactory.java Outdated Show resolved Hide resolved

src/main/java/org/jabref/model/entry/field/FieldFactory.java Show resolved Hide resolved

calixtus reviewed Apr 22, 2020

View reviewed changes

src/main/java/org/jabref/preferences/JabRefPreferences.java Outdated Show resolved Hide resolved

Siedlerchr added 2 commits April 24, 2020 19:15

change comment

7d21e06

koppor requested changes Apr 26, 2020

View reviewed changes

Siedlerchr added 3 commits April 27, 2020 18:49

Merge remote-tracking branch 'upstream/master' into multiline

1dc4fc5

* upstream/master: Backward compatibility for 4.3.1 (#6296) Fix Export to clipboard Dialog icon (#6345) Refactor EntryEditorPreferences (#6245)

add changelog

3fdb701

Merge branch 'master' into multiline

e99a550

Siedlerchr merged commit e0baa6d into master May 8, 2020

Siedlerchr deleted the multiline branch May 8, 2020 18:07

Siedlerchr mentioned this pull request May 8, 2020

Create a better solution for defining multiline fields #6448

Closed

ilippert mentioned this pull request May 10, 2020

multiline fields: cursor jumps to beginning of field #6457

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Make wrap fields also visible in entry editor #6315

Make wrap fields also visible in entry editor #6315

Siedlerchr commented Apr 19, 2020 •

edited

Loading

tobiasdiez left a comment

Siedlerchr commented Apr 24, 2020

koppor left a comment

koppor Apr 26, 2020

tobiasdiez Apr 26, 2020

Siedlerchr Apr 27, 2020

koppor Apr 26, 2020

calixtus commented May 8, 2020

Siedlerchr commented May 8, 2020

Make wrap fields also visible in entry editor #6315

Make wrap fields also visible in entry editor #6315

Conversation

Siedlerchr commented Apr 19, 2020 • edited Loading

tobiasdiez left a comment

Choose a reason for hiding this comment

Siedlerchr commented Apr 24, 2020

koppor left a comment

Choose a reason for hiding this comment

koppor Apr 26, 2020

Choose a reason for hiding this comment

tobiasdiez Apr 26, 2020

Choose a reason for hiding this comment

Siedlerchr Apr 27, 2020

Choose a reason for hiding this comment

koppor Apr 26, 2020

Choose a reason for hiding this comment

calixtus commented May 8, 2020

Siedlerchr commented May 8, 2020

Siedlerchr commented Apr 19, 2020 •

edited

Loading