-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove dash from illegal characters. #6300
Merged
Merged
Changes from 1 commit
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
2b7fad5
Remove dash from illegal characters. Fix #6295 #6257 #6252
dextep f332e42
Update bibtexkey incompatible characters.
dextep 38687aa
Add missing abbreviated journal names (#6292)
mayrmt feb6709
Change in CHANGELOG.md described.
dextep 23d9720
Revert "Add missing abbreviated journal names (#6292)"
dextep a90ac60
Update CHANGELOG.md
dextep ed42ac1
Update CHANGELOG.md
dextep 6fc9645
Renamed 'KEY_UNWANTED_CHARACTERS' to 'KEY_CHARACTERS_CAUSING_PARSING_…
dextep 00f8c92
Merged illegal `KEY_ILLEGAL_CHARACTERS` and disallowed `KEY_CHARACTER…
dextep e39cca3
Adapted the tests according to code updates.
dextep 471ec0e
Removed 'enforceLegalKey'.
dextep 19e0879
Removed "Enforce legal characters in BibTeX keys" option in the prefe…
dextep 2161cd1
Changes related to the review.
dextep ae8b183
Remove dash from illegal characters. Fix #6295 #6257 #6252
dextep 08257ff
Update bibtexkey incompatible characters.
dextep d0e5241
Change in CHANGELOG.md described.
dextep 8a510e3
Revert "Add missing abbreviated journal names (#6292)"
dextep d7d5ac7
Update CHANGELOG.md
dextep dda3259
Update CHANGELOG.md
dextep 7362457
Renamed 'KEY_UNWANTED_CHARACTERS' to 'KEY_CHARACTERS_CAUSING_PARSING_…
dextep fe43020
Merged illegal `KEY_ILLEGAL_CHARACTERS` and disallowed `KEY_CHARACTER…
dextep aae2b0e
Adapted the tests according to code updates.
dextep 4807493
Removed 'enforceLegalKey'.
dextep 0b1ca1a
Removed "Enforce legal characters in BibTeX keys" option in the prefe…
dextep d64b911
Changes related to the review.
dextep 6032766
Changes related to the review.
dextep 995ff60
Merge branch 'remove-dash-from-illegal-chars' of https://github.com/d…
dextep 4d37195
Merge remote-tracking branch 'upstream/master' into remove-dash-from-…
dextep 3f5b2e5
Fix checkstyle.
dextep 6db1344
Changes related to the review.
dextep c1ec4ad
Changes related to the review.
dextep cfeea59
Changes related to the review.
dextep File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't need the
unwantedChars
variable, do we? Can you please delete that for loop and the variable? --> the code on line 86 directly accesses the method parameterunwantedChararacters
!Side note: This is an example why similar variable names can be mixed up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Of course, we don't need it, I'm sorry. Every time I get the impression that I didn't notice something. 🐞