Entry editor: Add more tooltips and wrap tooltips if necessary #6239

systemoperator · 2020-04-03T13:54:40Z

Change in CHANGELOG.md described (if applicable)
Tests created for changes (if applicable)
Manually tested changed features in running JabRef (always required)
Screenshots added in PR description (for bigger UI changes)
Checked documentation: Is the information available and up to date? If not: Issue created at https://github.com/JabRef/user-documentation/issues.

systemoperator · 2020-04-03T16:07:48Z

The localization file will be updates as soon as no other changes are requested anymore.

tobiasdiez

Thanks for the completion of the fields! I've indeed some comments but nothing big.

src/main/java/org/jabref/gui/fieldeditors/FieldNameLabel.java

systemoperator · 2020-04-04T17:39:34Z

done

calixtus · 2020-04-05T17:04:32Z

Hi @systemoperator,
thanks for your PR.
I was just walking through all PRs to do some housekeeping in github. In some PRs the checkboxes were removed. Even if only one or two of them are applicable to a PR, please keep them, as they are helpful to us to get a quick overview of the extent to which a PR is ready.
I hope you don't mind if I readd them by myself.

systemoperator · 2020-04-05T17:09:51Z

Hi @systemoperator,
thanks for your PR.
I was just walking through all PRs to do some housekeeping in github. In some PRs the checkboxes were removed. Even if only one or two of them are applicable to a PR, please keep them, as they are helpful to us to get a quick overview of the extent to which a PR is ready.
I hope you don't mind if I readd them by myself.

@calixtus Thanks for the information. That's fine. I will keep it in mind. :)

koppor · 2020-04-06T04:29:57Z

src/main/java/org/jabref/gui/fieldeditors/FieldNameLabel.java

@@ -79,6 +109,8 @@ public String getDescription(Field field) {
                case FILE:
                case PDF:
                    return Localization.lang("Link(s) to a local PDF or other document of the work.");
+                case FOREWORD:
+                    return Localization.lang("Author(s) of a foreword to the work.");


The authors are separated by and? Maybe, this can be added here?

koppor · 2020-04-06T04:30:15Z

src/main/java/org/jabref/gui/fieldeditors/FieldNameLabel.java

                case JOURNALTITLE:
                case JOURNAL:
                    return Localization.lang("Name of a journal, a newspaper, or some other periodical.");
                case LABEL:
                    return Localization.lang("Designation to be used by the citation style as a substitute for the regular label if any data required to generate the regular label is missing.");
+                case LANGUAGE:
+                    return Localization.lang("Language(s) of the work. Languages may be specified literally or as localisation keys.");


How are multiple languages provided?

koppor · 2020-04-06T04:32:28Z

src/main/java/org/jabref/gui/fieldeditors/FieldNameLabel.java

                case KEYWORDS:
                    return Localization.lang("Separated list of keywords.");
+                case RELATED:
+                    return Localization.lang("Citation keys of other entries which have a relationship to this entry.");


Do we need to add "separated by ," here?

koppor

I have some minor comments on the text 😇

tobiasdiez · 2020-04-06T09:24:09Z

@koppor we agreed the last time that the description should only clarify the semantics of the field and not the bibtex conventions (e.g "and" as separator).

koppor · 2020-04-06T14:39:06Z

@koppor we agreed the last time that the description should only clarify the semantics of the field and not the bibtex conventions (e.g "and" as separator).

We should add an ADR here ^^. - Maybe later.

I fully agree for the author thing. I have doubts about the other entries though: What would be important for me is an example for "citation keys" and "languages". The issue is that we use different separators. and for names, , for keywords (even configurable) and (probably) , for these fields.

I really like the Java-by-Comparison approach - and they also favor examples. I would not go so far to make it as long as there:

However, a quick good example would be really helpful. That would avoid the user to change to a browser and google. Alternatively, the user is forced for a trial-and-error.

tobiasdiez · 2020-04-10T14:44:38Z

@koppor for these things, we have the integrity checks right?

I now merge this PR to move forward. Thanks @systemoperator for completing the descriptions!

* upstream/master: (23 commits) Bump junit-vintage-engine from 5.6.1 to 5.6.2 (#6276) Number of items found in ImportEntriesDialog (#6248) Fix dependency label Bump flexmark-ext-gfm-strikethrough from 0.61.0 to 0.61.6 (#6273) Bump unirest-java from 3.7.01 to 3.7.02 (#6275) Bump junit-platform-launcher from 1.6.1 to 1.6.2 (#6279) Bump flexmark-ext-gfm-tasklist from 0.61.0 to 0.61.6 (#6278) Bump junit-jupiter from 5.6.1 to 5.6.2 (#6274) Bump flexmark from 0.61.0 to 0.61.6 (#6280) Bump classgraph from 4.8.68 to 4.8.69 (#6277) Bump org.beryx.jlink from 2.17.4 to 2.17.5 (#6281) Improve performance (#6270) Improve calculation of matched entries upon change (#6268) Fix sort by priority (#6222) (#6265) Squashed 'src/main/resources/csl-styles/' changes from 88726cb..db54e56 Use https everywhere Entry editor: Add more tooltips and wrap tooltips if necessary (#6239) JDK14 switch - and checkstyle skipping (#6250) Bump postgresql from 42.2.11 to 42.2.12 (#6254) Bump unirest-java from 3.7.00 to 3.7.01 (#6253) ...

* upstream/master: (287 commits) Bump junit-vintage-engine from 5.6.1 to 5.6.2 (#6276) Number of items found in ImportEntriesDialog (#6248) Fix dependency label Bump flexmark-ext-gfm-strikethrough from 0.61.0 to 0.61.6 (#6273) Bump unirest-java from 3.7.01 to 3.7.02 (#6275) Bump junit-platform-launcher from 1.6.1 to 1.6.2 (#6279) Bump flexmark-ext-gfm-tasklist from 0.61.0 to 0.61.6 (#6278) Bump junit-jupiter from 5.6.1 to 5.6.2 (#6274) Bump flexmark from 0.61.0 to 0.61.6 (#6280) Bump classgraph from 4.8.68 to 4.8.69 (#6277) Bump org.beryx.jlink from 2.17.4 to 2.17.5 (#6281) Improve performance (#6270) Improve calculation of matched entries upon change (#6268) Fix sort by priority (#6222) (#6265) Squashed 'src/main/resources/csl-styles/' changes from 88726cb..db54e56 Use https everywhere Entry editor: Add more tooltips and wrap tooltips if necessary (#6239) JDK14 switch - and checkstyle skipping (#6250) Bump postgresql from 42.2.11 to 42.2.12 (#6254) Bump unirest-java from 3.7.00 to 3.7.01 (#6253) ...

systemoperator added 2 commits April 3, 2020 13:40

wrap tooltips if necessary

c1ac5d0

adding additional entry field tooltips (including SpecialFields)

eac2ac3

systemoperator mentioned this pull request Apr 3, 2020

Add tooltips for all entry types for #6074 #6203

Merged

systemoperator added 3 commits April 3, 2020 19:12

small changes

0d3af6b

ISRN added

f49c633

small changes

acf4374

tobiasdiez requested changes Apr 4, 2020

View reviewed changes

tobiasdiez added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Apr 4, 2020

descriptions adapted

c96530e

tobiasdiez approved these changes Apr 5, 2020

View reviewed changes

English localization extended

71667b3

koppor mentioned this pull request Apr 6, 2020

"invalid BibTex key" - warning when bibtex key includes a ":" #5982

Closed

koppor reviewed Apr 6, 2020

View reviewed changes

Merge remote-tracking branch 'upstream/master' into entry-field-tooltips

7b18ce1

tobiasdiez merged commit bdc5739 into JabRef:master Apr 10, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Entry editor: Add more tooltips and wrap tooltips if necessary #6239

Entry editor: Add more tooltips and wrap tooltips if necessary #6239

systemoperator commented Apr 3, 2020 •

edited

Loading

systemoperator commented Apr 3, 2020

tobiasdiez left a comment

systemoperator commented Apr 4, 2020

calixtus commented Apr 5, 2020

systemoperator commented Apr 5, 2020

koppor Apr 6, 2020

koppor Apr 6, 2020

koppor Apr 6, 2020

koppor left a comment

tobiasdiez commented Apr 6, 2020

koppor commented Apr 6, 2020

tobiasdiez commented Apr 10, 2020

Entry editor: Add more tooltips and wrap tooltips if necessary #6239

Entry editor: Add more tooltips and wrap tooltips if necessary #6239

Conversation

systemoperator commented Apr 3, 2020 • edited Loading

systemoperator commented Apr 3, 2020

tobiasdiez left a comment

Choose a reason for hiding this comment

systemoperator commented Apr 4, 2020

calixtus commented Apr 5, 2020

systemoperator commented Apr 5, 2020

koppor Apr 6, 2020

Choose a reason for hiding this comment

koppor Apr 6, 2020

Choose a reason for hiding this comment

koppor Apr 6, 2020

Choose a reason for hiding this comment

koppor left a comment

Choose a reason for hiding this comment

tobiasdiez commented Apr 6, 2020

koppor commented Apr 6, 2020

tobiasdiez commented Apr 10, 2020

systemoperator commented Apr 3, 2020 •

edited

Loading