Add paging support #6236
Merged
Add paging support #6236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* added paging interface * use collection instead of list * added default page size and documentation * removes interfaces from expected class list * Added paging support for ADS fetcher * removes search by page * make page immutable * added test case for invalid authors
# Conflicts: # src/test/java/org/jabref/logic/importer/WebFetchersTest.java
|
Open point: Add UI |
|
Merged, because required as logic module for JabRef#369. |
|
Why did you merged this? I thought we don't want to have half-finished code in our code base... You could have implemented the UI etc easily by PRs against this branch, as we had it for the JavaFX project. |
|
This functionality is required to get @DominikVoigt's implementation finished. As we write, he is working on it. Lean back and prepare for incoming pull requests the next days and weeks. Regarding the UI for the use case linked at #5518 we still need a volunteer though. |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By @JoHaHu. Let's discuss how to go on here.
Refs #5518.