-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Edition should not start capitalize letter #6149
Edition should not start capitalize letter #6149
Conversation
fabgio
commented
Mar 20, 2020
- Add EditionChecker feature to permit edition to begin with a number
- Add proper test
- Update CHANGELOG
…alized letter (field hint)
…alized letter (field hint) Test
…talized letter (field hint) update changelog
…n-should-not-start-capitalize-letter
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codewise this is fine so far, but you somehow have the wrong code style.
To avoid conflicts due to different code styles, we have created a custom code style for formatting.
See here for details:
https://github.com/JabRef/jabref/tree/master/config
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the contribution and welcome to JabRef 🎉
I have some "nitpick" comments. Some of them seem to be caused, because the steps we wrote at https://devdocs.jabref.org/getting-into-the-code/guidelines-for-setting-up-a-local-workspace#configure-your-ide were not fully followed. Can we do something to improve the howto?
src/test/java/org/jabref/logic/integrity/EditionCheckerTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/jabref/logic/integrity/EditionCheckerTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/jabref/logic/integrity/EditionCheckerTest.java
Outdated
Show resolved
Hide resolved
Remove space
Remove space
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some more comments 😇
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please do not remove the predefined RunConfiguration "JabRef_Main.xml".
Did all my best! |
…n-should-not-start-capitalize-letter
…n-should-not-start-capitalize-letter
Hi @fabgio, great work so far. I still see some problems with checkstyle. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So beautiful. ;-) LGTM.
I made all the improvments you suggest. i also semplified a nested if condition in EditionChecker class |
Codewise looks good to me! You still have some checkstyle issues, please resolve them so we can merge Just use reformat code Ctrl+Alt+L in the file |
Follow ups: @fabgio Thank you for the PR. Looking forward to more contributions. In case you are more keen to write some helping text, you are invited to join our efforts on improving the documetnation: https://github.com/JabRef/user-documentation/issues |