Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update open OpenOfficePanel to show buttons in three rows of three. #5789

Merged
merged 3 commits into from
Feb 6, 2020
Merged

Update open OpenOfficePanel to show buttons in three rows of three. #5789

merged 3 commits into from
Feb 6, 2020

Conversation

ddunig2
Copy link
Contributor

@ddunig2 ddunig2 commented Dec 28, 2019

Changed open office panel to show buttons in rows of three instead of going straight down to save space as the button expanded out to take up unnecessary horizontal space.

tobiasdiez
tobiasdiez requested changes Dec 28, 2019
View reviewed changes
Copy link
Member

@tobiasdiez tobiasdiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!
The code looks good to me. Can you please add a changelog entry; then this is good to go from my side.

@tobiasdiez tobiasdiez added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Dec 28, 2019
@ddunig2
Copy link
Contributor Author

ddunig2 commented Dec 29, 2019

I am not familiar with a change log entry, would you help me accomplish that please?

@tobiasdiez
Copy link
Member

We have a Changelog.md file listing all the relevant changes. Just add a sentence there and commit these changes: https://github.com/JabRef/jabref/blob/master/CHANGELOG.md#changed

@ddunig2
Copy link
Contributor Author

ddunig2 commented Jan 1, 2020

Should I create a pull request for that too or no?

@tobiasdiez
Copy link
Member

You can make the changes locally and then push them to your branch ddunig2:fix-for-issue-5479, which updates this PR automatically. No separate PR is necessary.

@koppor koppor removed the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Jan 2, 2020
@koppor
Copy link
Member

koppor commented Jan 2, 2020

@ddunig2 You can just work on your branch - a pull request collects all commits belonging to a branch. As soon as you pushed something, it will appear hear.

@tobiasdiez
Copy link
Member

@ddunig2 Did you already had the chance to add the changelog entry? It would be nice if you could do this so that we can merge your first pull request to JabRef. Thanks!

@ddunig2
Copy link
Contributor Author

ddunig2 commented Jan 31, 2020

I thought I did. I will double check.

@ddunig2
Copy link
Contributor Author

ddunig2 commented Feb 5, 2020

I remember doing this, although I'm not sure if I did it correctly. I redid it and these are the steps I took this time. I went on my fork and went on the branch I did my work on. Looked for the changelog file and add the change to the ##change section. I hope this is the right approach.

@tobiasdiez tobiasdiez merged commit 9407bef into JabRef:master Feb 6, 2020
@tobiasdiez
Copy link
Member

Thanks! You did it perfectly and everything is well now, so I'm going to merge. Looking forward to your next contribution. 😄

Siedlerchr added a commit that referenced this pull request Feb 8, 2020
@Siedlerchr
Merge remote-tracking branch 'upstream/master' into customizeEntrydlg
f456652 
* upstream/master:
  Update open OpenOfficePanel to show buttons in three rows of three. (#5789)
  update to javafx 13.02 (#5921)
  Update JDK14 from EA 30 to EA 34 (#5910)
Siedlerchr added a commit that referenced this pull request Mar 6, 2020
@Siedlerchr
Merge remote-tracking branch 'upstream/master'
38d11e6 
* upstream/master:
  Update to jdk 13.0.2 (#5924)
  Update Eclipse config
  Update open OpenOfficePanel to show buttons in three rows of three. (#5789)
  update to javafx 13.02 (#5921)
koppor pushed a commit that referenced this pull request Jan 1, 2022
Squashed 'buildres/csl/csl-styles/' changes from 60bf7d5..f78c707
1d32876 
f78c707 Update Turabian (full note) for 17.1.3.2 Reprint Editions (#5809)
2169ddc Create art-libraries-society-of-north-america-arlisna-reviews.csl (#5791)
94119a6 Create university-of-south-wales-harvard.csl (#5787)
470925c Update fachhochschule-sudwestfalen.csl (#5811)
1a9eff7 Create annals-of-public-and-cooperative-economics.csl (#5747)
d7477f2 Merge pull request #5368 from POBrien333/patch-862
113e683 Merge pull request #5812 from citation-style-language/apa-no-initials
62dacff Create universitat-oberta-de-catalunya-apa.csl
046482c Fix Organization Studies title
1213b95 Make oranization-studies dependent
c9641f4 Create apa-no-initials.csl
0b4e047 Modify american-journal-of-archaeology.csl (#5719)
ddeda4f Create journal-of-economic-impact.csl (#5707)
40c2696 Update gallia.csl (#5782)
5d5927a Create serbian-archives-of-medicine.csl (#5721)
2777954 Merge pull request #5807 from dhacker29/master
77e3fca Update Society of Biblical Literature Full Note for 6.1.6
4479a5a haaga-helia-university-of-applied-sciences-harvard.csl: no date cites need to be unique (#5726)
d00e046 Create university-of-roehampton-harvard.csl (#5732)
e76da40 Medicinski Razgledi -- fix locale
75b1554 Add original-date extra to proper place as per SBL Handbook 6.2.17-18 (#5725)
d43676e Update harvard-bournemouth-university.csl (#5667)
0312a39 Create ABNT NBR 6023:2018. UNESP – Faculdade de Engenharia de Guarati… (#5705)
6585ff9 Create sinergie-italian-journal-of-management.csl (#5776)
a7dc678 Create journal-of-global-health.csl (#5775)
02080ce Merge pull request #5800 from citation-style-language/validation-fixes
8b51d85 change s. d. to s.d. in french style for INBO reports (issue #2) (#5634)
1b4ec09 Create bloomsbury-academic.csl (#5741)
1f28d87 Create zeithistorische-forschungen.csl (#5766)
bb11942 Remove superfluous 'container' data from wiley-vch-books
06038a7 Remove et-al affixes
be96bd8 Remove et-al affixes from bibliotecae-it.csl
03a94e4 Remove more et-al affixes
07d7423 Revert non-et-al changes to universitat-basel-iberomanistik
f8e5fd8 Create medicinski-razgledi.csl (#5789)
b4df8ee Create dut-harvard.csl (#5762)
40855c4 Fix affixes on et-al
b4fe9b0 Merge pull request #5798 from citation-style-language/uris
3dc4aaf URL-encode documentation URLs
408a3a8 fixes citation-style-language/Sheldon#38
42aca5b Update biophysics-and-physicobiology.csl (#5751)
706bea0 Create universidade-do-porto-faculdade-de-engenharia-chicago-pt.csl (#5742)
269ff91 Update universidade-do-porto-faculdade-de-engenharia-chicago.csl (#5797)
0ba51e7 Update el-profesional-de-la-informacion.csl (#5785)
dac3baf Create arthropod-systematics-and-phylogeny.csl (#5772)
9dff241 Merge pull request #5796 from dhacker29/patch-1
35949f4 Update turabian-fullnote-bibliography-no-ibid.csl
ccfb661 Merge pull request #5793 from benjaminmoon/patch-2
520e127 Update frontiers-medical-journals.csl (#5740)
ab629ab Update natura-croatica.csl (#5795)
60b2b17 Rename turabian-fullnote-bibliography-no-ibid to turabian-fullnote-bibliography-no-ibid.csl
ad4edff Create turabian-fullnote-bibliography-no-ibid
d9b956c Update monographs-of-the-palaeontographical-society.csl
3648ae6 Merge pull request #5792 from StianOby/fix-no-page-number-articles
e15b2f7 Update norsk-henvisningsstandard-for-rettsvitenskapelige-tekster.csl
d8778cf Removed "page" (s. ) term for articles that do not have page numbers.
409017c add medium field for eBooks to MLA 8th

git-subtree-dir: buildres/csl/csl-styles
git-subtree-split: f78c707
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobiasdiez tobiasdiez tobiasdiez requested changes

@koppor koppor koppor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ddunig2 @tobiasdiez @koppor