Enable oracle tests

[koppor]

Enable test on Oracle XE. Fixes JabRef#151.

Oracle XE encrypted available at files.jabref.org. We have the password stored at koppor's KeePass and in the environment variable during the build. Thus, it can be decrypted during the test, but (hopefully) not by other persons.

• Remove obsolete ";" at SQL statement (ignored by non-Oracle-DB-systems)
• create prepared statement
• reformat code

[koppor]

Login into a local docker image works (after creating the jabref user)

$ docker exec -it  oracle-xe bash -c "source /home/oracle/.bashrc; /bin/bash -c '$ORACLE_HOME/bin/sqlplus jabref/jabref@localhost/XEPDB1'"

Then both following statements work:

SELECT ENTRY.SHARED_ID, ENTRY.TYPE, ENTRY.VERSION, F.ENTRY_SHARED_ID, F.NAME, F.VALUE FROM ENTRY inner join FIELD F on ENTRY.SHARED_ID = F.ENTRY_SHARED_ID order by SHARED_ID;

SELECT "ENTRY"."SHARED_ID", "ENTRY"."TYPE", "ENTRY"."VERSION", F."ENTRY_SHARED_ID", F."NAME", F."VALUE" FROM "ENTRY" inner join "FIELD" F on "ENTRY"."SHARED_ID" = F."ENTRY_SHARED_ID" order by "SHARED_ID";

But not when using the oracleJDBC driver:

23:14:30.001 [main] ERROR org.jabref.logic.shared.DBMSProcessor - Executed >SELECT ENTRY.SHARED_ID, ENTRY.TYPE, ENTRY.VERSION, F.ENTRY_SHARED_ID, F.NAME, F.VALUE FROM ENTRY inner join FIELD F on ENTRY.SHARED_ID = F.ENTRY_SHARED_ID where SHARED_ID in (1) order by SHARED_ID;< -  
23:14:30.001 [main] ERROR org.jabref.logic.shared.DBMSProcessor - SQL Error - java.sql.SQLSyntaxErrorException: ORA-00933: SQL-Befehl wurde nicht korrekt beendet

	at oracle.jdbc.driver.T4CTTIoer11.processError(T4CTTIoer11.java:509)
	at oracle.jdbc.driver.T4CTTIoer11.processError(T4CTTIoer11.java:461)
	at oracle.jdbc.driver.T4C8Oall.processError(T4C8Oall.java:1104)
	at oracle.jdbc.driver.T4CTTIfun.receive(T4CTTIfun.java:550) 

The simplest test case probably is: org.jabref.logic.shared.DBMSProcessorTest#testGetSharedEntry

[tobiasdiez]

The changes look good. However, now the build takes > 30 min, from originally 3-4 mins. Because of this, I would propose to extract the oracle tests to a separate workflow that runs regularly every week instead of at each commit.

[tobiasdiez]

The previous version was more readable in my opinion. What was the reason for this change?

[koppor]

Made id consistent with other parts of DBMSProcessor (saw it in the last pull requests going through. I especially reused the idea of #5659 (comment)).

[tobiasdiez]

[warning]Cache size of ~2455 MB (2573776080 B) is over the 400MB limit, not saving cache.

I think github will not increase the cache size that dramatically in the near future. Thus, this cache can be removed (which reduces the build time by 2 mins - not much but better than nothing).

[Siedlerchr]

For caching, see the discussion here: actions/cache#6

[koppor]

Result of the discussion:

There may be another update soon to up the limit a little (~700MB or so), [...] We would still have the 2GB per repo limit until we integrate billing, so there would be some concern about thrashing the cache if the individual limit matched the per repo limit.