Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making importing a single file easier (Issue #5508) #5513

Merged
merged 4 commits into from
Nov 3, 2019
Merged

Making importing a single file easier (Issue #5508) #5513

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9dae8e5
Added condition: if only one entry is imported, it automatically sele…
P4trice Oct 25, 2019
50270d6
trying Platform.runLater around the if-statement, also tried around e…
P4trice Oct 29, 2019
60e8e73
reverted the last change and added a comment as to why the code is there
P4trice Oct 31, 2019
216aad4
fixed a mistake, where 2 returns where present, where one was not nec…
P4trice Nov 1, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/main/java/org/jabref/gui/importer/ImportEntriesDialog.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,16 @@ private void initialize() {
}
}).executeWith(Globals.TASK_EXECUTOR);

/*
inserted the if-statement here, since a Platforn.runLater() call did not work.
also tried to move it to the end of the initialize method, but it did not select the entry.
*/
if (entriesListView.getItems().size() == 1) {
selectAllNewEntries();
}

return container;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now you have two return statements 🦊

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am so sorry for all the inconveniences. I'll correct it immediately.


return container;
})
.withOnMouseClickedEvent((entry, event) -> entriesListView.getCheckModel().toggleCheckState(entry))
Expand Down