Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open entry editor by default on start-up #5488

Merged
merged 2 commits into from
Oct 21, 2019
Merged

Open entry editor by default on start-up #5488

merged 2 commits into from
Oct 21, 2019

Conversation

CaptainDaVinci
Copy link
Contributor

Fixes #5460

Select the first entry in the main table, and opens entry editor
for the same. This action is performed on the application thread.

  • Change in CHANGELOG.md described
  • Tests created for changes
  • Manually tested changed features in running JabRef
  • Screenshots added in PR description (for bigger UI changes)
  • Ensured that the git commit message is a good one
  • Check documentation status (Issue created for outdated help page at help.jabref.org?)

@CaptainDaVinci
Open entry editor by default on start-up
96491c4 
Fixes JabRef#5460

Select the first entry in the main table, and open entry editor
for the same. This action is performed on the application thread.
tobiasdiez
tobiasdiez requested changes Oct 20, 2019
View reviewed changes
Copy link
Member

@tobiasdiez tobiasdiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! Please add a changelog entry. Apart from that we can merge from my point of view.

@tobiasdiez tobiasdiez added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Oct 20, 2019
@Siedlerchr Siedlerchr merged commit 0f0dce6 into JabRef:master Oct 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobiasdiez tobiasdiez tobiasdiez approved these changes

@Siedlerchr Siedlerchr Siedlerchr approved these changes

Assignees
No one assigned
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Entry editor: Keep it open as default
3 participants
@CaptainDaVinci @Siedlerchr @tobiasdiez