Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to display entry preview as tab in entry editor #5451

Merged
merged 5 commits into from
Oct 16, 2019
Merged

Add option to display entry preview as tab in entry editor #5451

merged 5 commits into from
Oct 16, 2019

Conversation

tobiasdiez
Copy link
Member

@tobiasdiez tobiasdiez commented Oct 15, 2019 •
edited
Loading

Adds the entry preview as a tab. Fixes #5244. Also fixes #5446. Plus a bit of refactoring

image

  • Change in CHANGELOG.md described
  • Tests created for changes
  • Manually tested changed features in running JabRef
  • Screenshots added in PR description (for bigger UI changes)
  • Ensured that the git commit message is a good one
  • Check documentation status (Issue created for outdated help page at help.jabref.org?)

@tobiasdiez
Add option to display entry preview as tab in entry editor
d82408c 
Adds the entry preview as a tab. Fixes #5244. Plus a bit of refactoring
@tobiasdiez tobiasdiez added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Oct 15, 2019
@tobiasdiez tobiasdiez merged commit e36daae into master Oct 16, 2019
@tobiasdiez tobiasdiez deleted the previewTab branch October 16, 2019 19:01
@calixtus calixtus mentioned this pull request Oct 17, 2019
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Siedlerchr Siedlerchr Siedlerchr approved these changes

Assignees
No one assigned
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Milestone
No milestone
2 participants
@tobiasdiez @Siedlerchr