-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
English grammar and typo fixes in CONTRIBUTING.md #5414
Conversation
bharatr21
commented
Oct 9, 2019
•
edited
Loading
edited
- Change in CHANGELOG.md described
- Tests created for changes
- Manually tested changed features in running JabRef
- Screenshots added in PR description (for bigger UI changes)
- Ensured that the git commit message is a good one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your quick update.
Could you also fix the linting isuses in the markdown file? (Think empty line after the heading is missing) --> https://github.com/DavidAnson/vscode-markdownlint
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me now. Thank you for these improvements. If you like continuing working on JabRef, have a look at the issues as well (;
I did not make myself clear. I just wanted to have the empty line removed. I like the new text. I will revert the revert, remove the empty line and then merge. |
Merged in e393a10 |