Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

English grammar and typo fixes in CONTRIBUTING.md #5414

Closed
wants to merge 3 commits into from

Conversation

bharatr21
Copy link
Contributor

@bharatr21 bharatr21 commented Oct 9, 2019


  • Change in CHANGELOG.md described
  • Tests created for changes
  • Manually tested changed features in running JabRef
  • Screenshots added in PR description (for bigger UI changes)
  • Ensured that the git commit message is a good one

Copy link
Member

@koppor koppor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your quick update.

Could you also fix the linting isuses in the markdown file? (Think empty line after the heading is missing) --> https://github.com/DavidAnson/vscode-markdownlint

@koppor koppor changed the title English grammar and typo fixes in CONTRIBUTING.md [WIP] English grammar and typo fixes in CONTRIBUTING.md Oct 9, 2019
@bharatr21 bharatr21 changed the title [WIP] English grammar and typo fixes in CONTRIBUTING.md English grammar and typo fixes in CONTRIBUTING.md Oct 10, 2019
Copy link
Member

@LinusDietz LinusDietz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me now. Thank you for these improvements. If you like continuing working on JabRef, have a look at the issues as well (;

@koppor
Copy link
Member

koppor commented Oct 10, 2019

I did not make myself clear. I just wanted to have the empty line removed. I like the new text.

I will revert the revert, remove the empty line and then merge.

@koppor
Copy link
Member

koppor commented Oct 10, 2019

Merged in e393a10

@koppor koppor closed this Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants