Fix for #5369 - fallback to 0 in case stored preview cycle pos does no longer exist #5382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthiasgeiger
added
the
status: ready-for-review
Siedlerchr
approved these changes
Oct 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #5369
problem should in theory not happen as always a correct size should be stored - however, if for example CSL styles are not loaded properly the mentioned exception in #5369 might occur.
To prevent this upon creating the preview prefs now the stored cycle position is now compared to the actual list of previews before being set.
[ ] Tests created for changes[ ] Screenshots added in PR description (for bigger UI changes)[ ] Check documentation status (Issue created for outdated help page at help.jabref.org?)