Import Format Reader Fix #531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please add a CHANGELOG entry as this fixes #479 |
simonharrer
added
stupro
bug
boceckts
force-pushed
the
IsRecognizedFormatFix
branch
from
e94db1c to
2b929c7
Compare
|
Probably some line ending issue as all lines in ImportFormatReader are marked as changed and a new copy of the CHANGELOG is appended at the start of it. |
The stream could not be resetted without a BufferedInputStream. However this is necessary since we check if a import file is in the right format with looking into the stream and searching for specific patterns. This fixes the issue without changing any method interfaces.
boceckts
force-pushed
the
IsRecognizedFormatFix
branch
from
2b929c7 to
c0ec6d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Problem is, that the stream can not be resetted without a BufferedInputStream.
However this is necessary since we check if a import file is in the right format with
looking into the stream and searching for specific patterns.
Result of the above mentioned issue is that I always got an error message saying
"No entries found" when trying to import a file with a valid format and entries.
This fixes the issue without changing any method interfaces.