Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select push app in preferences #5024

Merged
merged 30 commits into from
Jun 4, 2019
Merged
Changes from 1 commit
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
2e6896b
Added Submenu to change external push-app
calixtus May 22, 2019
f420082
Rewording, Respacing and Optimizing
calixtus May 22, 2019
1883f6f
Rewording Confusing PushApplications to PushToApplicationsManager
calixtus May 22, 2019
d0aa24c
Refactoring and unifying PtAAction with ToolbarButton
calixtus May 22, 2019
6fa926f
Refactor simplified
calixtus May 22, 2019
f48a9d4
Reword l10n
calixtus May 22, 2019
746e025
Refactor for checks
calixtus May 22, 2019
5d6a7cf
Added eye-candy
calixtus May 22, 2019
a8b6489
Added eye-candy
calixtus May 22, 2019
186f9bc
Changelog
calixtus May 22, 2019
ec5f96b
whitespaces
calixtus May 22, 2019
91e4393
Merge remote-tracking branch 'upstream/master' into menu_select_push_app
calixtus May 30, 2019
2ce9d37
Rewording, Sorting, Simplifying
calixtus May 30, 2019
e66586e
Whitespace
calixtus May 30, 2019
a91455d
Rewording, Sorting
calixtus May 30, 2019
eddbe0a
Refactor var-declaration
calixtus Jun 2, 2019
fadd6ce
Removed Submenu and Added Preferences Setting
calixtus Jun 2, 2019
96e4b6f
Fixed compiletime-error
calixtus Jun 2, 2019
734e8c9
Added App-settings-button
calixtus Jun 2, 2019
fd18502
Changelog
calixtus Jun 2, 2019
6ae31aa
Whitespaces and superflous
calixtus Jun 2, 2019
26a1c93
Revert persistent actionInformation
calixtus Jun 2, 2019
4084701
Merge branch 'menu_select_push_app' into pref_select_push_app
calixtus Jun 2, 2019
2f1637a
Removed superfluous declaration
calixtus Jun 2, 2019
3fa27df
Merge branch 'menu_select_push_app' into pref_select_push_app
calixtus Jun 2, 2019
4b0862c
Added eyecandy
calixtus Jun 4, 2019
435a87f
Refactor so simplify
calixtus Jun 4, 2019
4406e1a
Refactor for some minor requests
calixtus Jun 4, 2019
89ac2fe
Refactor of PushToApplicationSettings
calixtus Jun 4, 2019
dbed029
Checkstyle
calixtus Jun 4, 2019
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fixed compiletime-error
  • Loading branch information
calixtus committed Jun 2, 2019
commit 96e4b6fe17b4d11615444352926ab3dc86cc367c
Original file line number Diff line number Diff line change
@@ -16,6 +16,7 @@
import org.jabref.model.database.BibDatabaseContext;
import org.jabref.model.entry.BibEntry;
import org.jabref.model.strings.StringUtil;
import org.jabref.preferences.JabRefPreferences;

import static org.jabref.gui.actions.ActionHelper.needsDatabase;
import static org.jabref.gui.actions.ActionHelper.needsEntriesSelected;
@@ -32,7 +33,7 @@ public class PushToApplicationAction extends SimpleCommand {
private Action action;

public PushToApplicationAction(StateManager stateManager, PushToApplicationsManager pushToApplicationsManager, DialogService dialogService) {
this.application = pushToApplicationsManager.getActiveApplication(Globals.prefs);
this.application = pushToApplicationsManager.getApplicationByName(Globals.prefs.get(JabRefPreferences.PUSH_TO_APPLICATION));
calixtus marked this conversation as resolved.
Show resolved Hide resolved
this.stateManager = stateManager;
this.dialogService = dialogService;