Too big error message #4827

[dimmonn]

Fixes #4827

checking if the error belongs to sql state 01S00 then it gets shortened to the first dot.

ex.
this: The server time zone value 'MSK' is unrecognized or represents more than one time zone. You must configure either the server or JDBC driver (via the serverTimezone configuration property) to use a more specifc time zone value if you want to utilize time zone support.

becomes:
The server time zone value 'MSK' is unrecognized or represents more than one time zone

if there is no dot in error string it remains the same length

[Siedlerchr]

Thanks for your contribution. However I think it would be better if you just add the second sentence to a new line.

[dimmonn]

Thanks, gotcha

[tobiasdiez]

It might also work to play around with setWidth here:

jabref/src/main/java/org/jabref/gui/JabRefDialogService.java

Lines 165 to 178 in 3baa6bd

	@Override
	public void showErrorDialogAndWait(String message, Throwable exception) {
	ExceptionDialog exceptionDialog = new ExceptionDialog(exception);
	exceptionDialog.setHeaderText(message);
	exceptionDialog.showAndWait();
	}
	@Override
	public void showErrorDialogAndWait(String title, String content, Throwable exception) {
	ExceptionDialog exceptionDialog = new ExceptionDialog(exception);
	exceptionDialog.setHeaderText(title);
	exceptionDialog.setContentText(content);
	exceptionDialog.showAndWait();
	}

This has the advantage, that it would fix similar errors that occur elsewhere.

[dimmonn]

Right I'll try

[dimmonn]

formatted the error message instead, every 25th word ends up as a new line, eventually it looks like below.

(org/jabref/gui/JabRefDialogService.java:167 setWidth here works a bit unexpected with the long string lines, so I didn't play around with the setWidth)

[davidemdot]

Hey, @dimmonn. It looks that there is a problem with the Checkstyle test. You should insert a blank line before org.slf4j.Logger and remove one of the two empty lines after org.slf4j.LoggerFactory:

import org.jabref.model.database.shared.DatabaseConnection;

import org.slf4j.Logger;
import org.slf4j.LoggerFactory;

public class DBMSConnection implements DatabaseConnection {

Thanks for your contribution!

[dimmonn]

Got you, many thanks will fix now

[Siedlerchr]

thanks for your contribution! LGTM

[tobiasdiez]

Thanks for the follow-up. It's too bad that the Dialog.setWidth method doesn't work. May I ask you to also try to use Dialog.getDialogPane().setPrefWidth (or setMaxWidthorsetWidth`). If this also doesn't work, then we can merge your current solution. Thanks!

[tobiasdiez]

Please compare it directly to the expected error message (e.g `assertEquals("...", errorToBeThrown)).

[dimmonn]

done

[dimmonn]

@tobiasdiez

any type of setWidth seems to cut off the string, unless I do it incorrectly

ex,
exceptionDialog.getDialogPane().setMaxWidth(mainWindow.getWidth() / 3);

[tobiasdiez]

Thanks for testing. It seems to be a bug in the library we use. I've proposed a fix at controlsfx/controlsfx#1155. Let's hope they include it quickly. If not, then we can temporarily go with your fix and then at some point fix it in the dialog service class.

[dimmonn]

Cool, thanks
The controlsfx folks might do it similar way by adding new lines when dialog gets squeezed in with new width :)

[tobiasdiez]

It should be fixed now in controlsfx. To see it you need to change
https://github.com/JabRef/jabref/blob/master/build.gradle#L139
to controlsfx-8.40.16.

[dimmonn]

updated lib works well

not sure if some unit tests needs to cover this change

[Siedlerchr]

maybe: where a database exception related to a missing timezone was too big?
(cause otherwise it sounds a bit confusing

[dimmonn]

sure, done

[Siedlerchr]

lgtm. Thanks for the work!
Just improve the changelog entry a bit and we can merge

[Siedlerchr]

Thanks for your contribution: PS: If you write sth like Fixes #1234 then the corresponding issue will be automatically closed on merge