Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modifications to improve contrast of UI elements #4758

Merged
merged 2 commits into from
Mar 14, 2019
Merged

Modifications to improve contrast of UI elements #4758

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b285a21
Modifications to improve contrast of UI elements
samiyac Mar 12, 2019
465e0f9
Merge branch 'master' into fix-for-issue-4583
samiyac Mar 12, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ We refer to [GitHub issues](https://github.com/JabRef/jabref/issues) by using `#
- We grouped the toolbar icons and changed the Open Library and Copy icons. [#4584](https://github.com/JabRef/jabref/issues/4584)
- We added a browse button next to the path text field for aux-based groups. [#4586](https://github.com/JabRef/jabref/issues/4586)
- We changed the title of Group Dialog to "Add subgroup" from "Edit group" when we select Add subgroup option.

- We made modifications to improve contrast of UI elements. [#4583](https://github.com/JabRef/jabref/issues/4583)

### Fixed
- We fixed an issue where corresponding groups are sometimes not highlighted when clicking on entries [#3112](https://github.com/JabRef/jabref/issues/3112)
Expand Down
10 changes: 5 additions & 5 deletions src/main/java/org/jabref/gui/Base.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@

-jr-white: #ffffff;
-jr-gray-0: #f2f2f2;
-jr-gray-1: #e6e6e6;
-jr-gray-1: #dddddd;
-jr-gray-2: #808080;
-jr-gray-3: #404040;
-jr-black: #000;
Expand Down Expand Up @@ -70,7 +70,7 @@
-jr-error: -jr-light-red;

/* Color for the small group view indicator for the number of hits */
-jr-group-hits-bg: derive(-jr-sidepane-background, -5%);
-jr-group-hits-bg: derive(-jr-sidepane-background, -50%);
-jr-group-hits-fg: ladder(
-jr-group-hits-bg,
-fx-light-text-color 45%,
Expand All @@ -84,8 +84,8 @@
-jr-tooltip-fg: -jr-black;

/* Finally, some specific jr styles that depend on -fx definitions in *this* style */
-jr-sidepane-background: -jr-gray-0;
-jr-sidepane-header-background: -jr-gray-0;
-jr-sidepane-background: -jr-gray-1;
-jr-sidepane-header-background: -jr-gray-1;
-jr-sidepane-header-color: -jr-theme-text;

/* Specs for the scrollbars */
Expand Down Expand Up @@ -116,7 +116,7 @@
*/
-fx-control-inner-background: derive(-fx-base, 95%);
/* Version of -fx-control-inner-background for alternative rows */
-fx-control-inner-background-alt: derive(-fx-control-inner-background, -2%);
-fx-control-inner-background-alt: derive(-fx-control-inner-background, -6%);

/* One of these colors will be chosen based upon a ladder calculation
* that uses the brightness of a background color. Instead of using these
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/org/jabref/gui/groups/GroupTree.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
.numberColumn > .hits {
-fx-font-size: 85%;
-fx-background-color: -jr-group-hits-bg;
-fx-padding: 0.1em 0.4em 0.1em 0.4em;
-fx-padding: 0.4em 0.4em 0.4em 0.4em;
-fx-background-insets: 0;
-fx-background-radius: 0.8em;
}
Expand Down