Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert "Manage external file types" dialog to JavaFX #4711

Merged
merged 3 commits into from
Mar 8, 2019
Merged

Convert "Manage external file types" dialog to JavaFX #4711

merged 3 commits into from
Mar 8, 2019

Conversation

tobiasdiez
Copy link
Member

Before:
image

After:
image

  • Change in CHANGELOG.md described
  • Tests created for changes
  • Manually tested changed features in running JabRef
  • Screenshots added in PR description (for bigger UI changes)
  • Ensured that the git commit message is a good one
  • Check documentation status (Issue created for outdated help page at help.jabref.org?)

@tobiasdiez tobiasdiez added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Mar 2, 2019
@Siedlerchr
Copy link
Member

Please also remove the method public static void setSwingContent(DialogPane dialogPane, JComponent content) { from the ControlHelper class. The ExternalFileTypEditor is the only thing where it is used

@tobiasdiez
Copy link
Member Author

Will remove all the old unused Swig stuff in a separate PR.

@tobiasdiez tobiasdiez merged commit c16f733 into master Mar 8, 2019
@tobiasdiez tobiasdiez deleted the convertFileTypes branch March 8, 2019 14:31
Siedlerchr added a commit that referenced this pull request Mar 8, 2019
@Siedlerchr
Merge remote-tracking branch 'upstream/master' into libraryproperties…
ad5291f 
…tofx

* upstream/master: (25 commits)
  Convert "Manage external file types" dialog to JavaFX (#4711)
  Remove add/move/remove from group dialog (#4695)
  Fix entry preview copy exception (#4721)
  Fix default import format pattern (#4731)
  Add key bindings (#4732)
  Convert "wait for save" dialog to JavaFX (#4697)
  Add changes to CHANGELOG and fix New Library icons
  Adding GENERATE_CITE_KEYS button to toolbar.
  Change toolbar icons and add separators
  Adding additional modifiers to be used in bibtex key generator
  Adding "von" part to Author's last name when exporting to MS Office 2007 (#4725)
  Bump mockito-core from 2.24.5 to 2.25.0 (#4723)
  remove obsolete localization strings fix checkstyle
  fix build
  cleanup
  convert file chooser in preferences
  remove unused swing stuff convert help  buttons
  Fix #4703: Newline format couldn't be changed (#4720)
  Group and reorder the Main Menu (tabs & icons) (#4707)
  Convert Manage keywords dialog to JavaFX (#4701)
  ...
github-actions bot pushed a commit that referenced this pull request Apr 30, 2020
Squashed 'src/main/resources/csl-styles/' changes from 143464e..906cd6d
86550b3 
906cd6d Create technische-universitat-dresden-linguistik-author-date (#4730)
607a056 Create ifao-publications.csl (#4731)
5a65f50 remove et-al settings for bibliography for PVS (#4735)
4a145d4 Create current-opinion-in-endocrinology-diabetes-and-obesity.csl (#4734)
d70c2a4 Add chapter section in bibliography (#4732)
366dbc1 Create economic-history-review.csl (#4643)
7069ddc Create the-open-university-harvard-s390-modules.csl (#4711)
a789973 Chicago: Uppercase "Presentated at" if no `genre` (#4729)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: 906cd6d
github-actions bot pushed a commit to CaptainDaVinci/jabref that referenced this pull request May 1, 2020
Squashed 'src/main/resources/csl-styles/' changes from c1793d2..906cd6d
366f3b0 
906cd6d Create technische-universitat-dresden-linguistik-author-date (JabRef#4730)
607a056 Create ifao-publications.csl (JabRef#4731)
5a65f50 remove et-al settings for bibliography for PVS (JabRef#4735)
4a145d4 Create current-opinion-in-endocrinology-diabetes-and-obesity.csl (JabRef#4734)
d70c2a4 Add chapter section in bibliography (JabRef#4732)
366dbc1 Create economic-history-review.csl (JabRef#4643)
7069ddc Create the-open-university-harvard-s390-modules.csl (JabRef#4711)
a789973 Chicago: Uppercase "Presentated at" if no `genre` (JabRef#4729)
143464e Fix comma before et al. for the-oncologist.csl (JabRef#4724)
3b331b6 fixed bug with "near-note" position univ.-bordeaux-ecole-doctorale-de… (JabRef#4719)
b2c0c1e APA: in-text title in title-case (JabRef#4725)
88c68d2 Fix et-al and indetation settings for mammalia.csl (JabRef#4717)
05940a2 Update the-febs-journal.csl (JabRef#4720)
1d77ba8 Request for review and assessment of the repa.csl (JabRef#4698)
76b4be5 Update isnad.csl (JabRef#4716)
f709c84 Update isnad-dipnotlu.csl (JabRef#4715)
45d7655 Create mammalia.csl (JabRef#4714)
eb333ca Update society-for-american-archaeology.csl (JabRef#4710)
d944e71 Update masarykova-univerzita-pravnicka-fakulta.csl (JabRef#4712)
5e34eb1 Update animal-welfare.csl (JabRef#4713)
06785fa Update le-tapuscrit-author-date.csl (JabRef#4708)
ada5282 Update norois.csl (JabRef#4707)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: 906cd6d
github-actions bot pushed a commit to calixtus/jabref that referenced this pull request May 1, 2020
Squashed 'src/main/resources/csl-styles/' changes from c1793d2..906cd6d
34d37f0 
906cd6d Create technische-universitat-dresden-linguistik-author-date (JabRef#4730)
607a056 Create ifao-publications.csl (JabRef#4731)
5a65f50 remove et-al settings for bibliography for PVS (JabRef#4735)
4a145d4 Create current-opinion-in-endocrinology-diabetes-and-obesity.csl (JabRef#4734)
d70c2a4 Add chapter section in bibliography (JabRef#4732)
366dbc1 Create economic-history-review.csl (JabRef#4643)
7069ddc Create the-open-university-harvard-s390-modules.csl (JabRef#4711)
a789973 Chicago: Uppercase "Presentated at" if no `genre` (JabRef#4729)
143464e Fix comma before et al. for the-oncologist.csl (JabRef#4724)
3b331b6 fixed bug with "near-note" position univ.-bordeaux-ecole-doctorale-de… (JabRef#4719)
b2c0c1e APA: in-text title in title-case (JabRef#4725)
88c68d2 Fix et-al and indetation settings for mammalia.csl (JabRef#4717)
05940a2 Update the-febs-journal.csl (JabRef#4720)
1d77ba8 Request for review and assessment of the repa.csl (JabRef#4698)
76b4be5 Update isnad.csl (JabRef#4716)
f709c84 Update isnad-dipnotlu.csl (JabRef#4715)
45d7655 Create mammalia.csl (JabRef#4714)
eb333ca Update society-for-american-archaeology.csl (JabRef#4710)
d944e71 Update masarykova-univerzita-pravnicka-fakulta.csl (JabRef#4712)
5e34eb1 Update animal-welfare.csl (JabRef#4713)
06785fa Update le-tapuscrit-author-date.csl (JabRef#4708)
ada5282 Update norois.csl (JabRef#4707)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: 906cd6d
github-actions bot pushed a commit to eetian/jabref that referenced this pull request May 1, 2020
Squashed 'src/main/resources/csl-styles/' changes from c1793d2..906cd6d
c828159 
906cd6d Create technische-universitat-dresden-linguistik-author-date (JabRef#4730)
607a056 Create ifao-publications.csl (JabRef#4731)
5a65f50 remove et-al settings for bibliography for PVS (JabRef#4735)
4a145d4 Create current-opinion-in-endocrinology-diabetes-and-obesity.csl (JabRef#4734)
d70c2a4 Add chapter section in bibliography (JabRef#4732)
366dbc1 Create economic-history-review.csl (JabRef#4643)
7069ddc Create the-open-university-harvard-s390-modules.csl (JabRef#4711)
a789973 Chicago: Uppercase "Presentated at" if no `genre` (JabRef#4729)
143464e Fix comma before et al. for the-oncologist.csl (JabRef#4724)
3b331b6 fixed bug with "near-note" position univ.-bordeaux-ecole-doctorale-de… (JabRef#4719)
b2c0c1e APA: in-text title in title-case (JabRef#4725)
88c68d2 Fix et-al and indetation settings for mammalia.csl (JabRef#4717)
05940a2 Update the-febs-journal.csl (JabRef#4720)
1d77ba8 Request for review and assessment of the repa.csl (JabRef#4698)
76b4be5 Update isnad.csl (JabRef#4716)
f709c84 Update isnad-dipnotlu.csl (JabRef#4715)
45d7655 Create mammalia.csl (JabRef#4714)
eb333ca Update society-for-american-archaeology.csl (JabRef#4710)
d944e71 Update masarykova-univerzita-pravnicka-fakulta.csl (JabRef#4712)
5e34eb1 Update animal-welfare.csl (JabRef#4713)
06785fa Update le-tapuscrit-author-date.csl (JabRef#4708)
ada5282 Update norois.csl (JabRef#4707)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: 906cd6d
github-actions bot pushed a commit to leitianjian/jabref that referenced this pull request May 1, 2020
Squashed 'src/main/resources/csl-styles/' changes from 06785fa..906cd6d
19d2d5c 
906cd6d Create technische-universitat-dresden-linguistik-author-date (JabRef#4730)
607a056 Create ifao-publications.csl (JabRef#4731)
5a65f50 remove et-al settings for bibliography for PVS (JabRef#4735)
4a145d4 Create current-opinion-in-endocrinology-diabetes-and-obesity.csl (JabRef#4734)
d70c2a4 Add chapter section in bibliography (JabRef#4732)
366dbc1 Create economic-history-review.csl (JabRef#4643)
7069ddc Create the-open-university-harvard-s390-modules.csl (JabRef#4711)
a789973 Chicago: Uppercase "Presentated at" if no `genre` (JabRef#4729)
143464e Fix comma before et al. for the-oncologist.csl (JabRef#4724)
3b331b6 fixed bug with "near-note" position univ.-bordeaux-ecole-doctorale-de… (JabRef#4719)
b2c0c1e APA: in-text title in title-case (JabRef#4725)
88c68d2 Fix et-al and indetation settings for mammalia.csl (JabRef#4717)
05940a2 Update the-febs-journal.csl (JabRef#4720)
1d77ba8 Request for review and assessment of the repa.csl (JabRef#4698)
76b4be5 Update isnad.csl (JabRef#4716)
f709c84 Update isnad-dipnotlu.csl (JabRef#4715)
45d7655 Create mammalia.csl (JabRef#4714)
eb333ca Update society-for-american-archaeology.csl (JabRef#4710)
d944e71 Update masarykova-univerzita-pravnicka-fakulta.csl (JabRef#4712)
5e34eb1 Update animal-welfare.csl (JabRef#4713)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: 906cd6d
github-actions bot pushed a commit to abepolk/jabref that referenced this pull request May 1, 2020
Squashed 'src/main/resources/csl-styles/' changes from c1793d2..906cd6d
1bc990d 
906cd6d Create technische-universitat-dresden-linguistik-author-date (JabRef#4730)
607a056 Create ifao-publications.csl (JabRef#4731)
5a65f50 remove et-al settings for bibliography for PVS (JabRef#4735)
4a145d4 Create current-opinion-in-endocrinology-diabetes-and-obesity.csl (JabRef#4734)
d70c2a4 Add chapter section in bibliography (JabRef#4732)
366dbc1 Create economic-history-review.csl (JabRef#4643)
7069ddc Create the-open-university-harvard-s390-modules.csl (JabRef#4711)
a789973 Chicago: Uppercase "Presentated at" if no `genre` (JabRef#4729)
143464e Fix comma before et al. for the-oncologist.csl (JabRef#4724)
3b331b6 fixed bug with "near-note" position univ.-bordeaux-ecole-doctorale-de… (JabRef#4719)
b2c0c1e APA: in-text title in title-case (JabRef#4725)
88c68d2 Fix et-al and indetation settings for mammalia.csl (JabRef#4717)
05940a2 Update the-febs-journal.csl (JabRef#4720)
1d77ba8 Request for review and assessment of the repa.csl (JabRef#4698)
76b4be5 Update isnad.csl (JabRef#4716)
f709c84 Update isnad-dipnotlu.csl (JabRef#4715)
45d7655 Create mammalia.csl (JabRef#4714)
eb333ca Update society-for-american-archaeology.csl (JabRef#4710)
d944e71 Update masarykova-univerzita-pravnicka-fakulta.csl (JabRef#4712)
5e34eb1 Update animal-welfare.csl (JabRef#4713)
06785fa Update le-tapuscrit-author-date.csl (JabRef#4708)
ada5282 Update norois.csl (JabRef#4707)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: 906cd6d
github-actions bot pushed a commit to NikodemKch/jabref-1 that referenced this pull request May 1, 2020
Squashed 'src/main/resources/csl-styles/' changes from c1793d2..906cd6d
67a38d3 
906cd6d Create technische-universitat-dresden-linguistik-author-date (JabRef#4730)
607a056 Create ifao-publications.csl (JabRef#4731)
5a65f50 remove et-al settings for bibliography for PVS (JabRef#4735)
4a145d4 Create current-opinion-in-endocrinology-diabetes-and-obesity.csl (JabRef#4734)
d70c2a4 Add chapter section in bibliography (JabRef#4732)
366dbc1 Create economic-history-review.csl (JabRef#4643)
7069ddc Create the-open-university-harvard-s390-modules.csl (JabRef#4711)
a789973 Chicago: Uppercase "Presentated at" if no `genre` (JabRef#4729)
143464e Fix comma before et al. for the-oncologist.csl (JabRef#4724)
3b331b6 fixed bug with "near-note" position univ.-bordeaux-ecole-doctorale-de… (JabRef#4719)
b2c0c1e APA: in-text title in title-case (JabRef#4725)
88c68d2 Fix et-al and indetation settings for mammalia.csl (JabRef#4717)
05940a2 Update the-febs-journal.csl (JabRef#4720)
1d77ba8 Request for review and assessment of the repa.csl (JabRef#4698)
76b4be5 Update isnad.csl (JabRef#4716)
f709c84 Update isnad-dipnotlu.csl (JabRef#4715)
45d7655 Create mammalia.csl (JabRef#4714)
eb333ca Update society-for-american-archaeology.csl (JabRef#4710)
d944e71 Update masarykova-univerzita-pravnicka-fakulta.csl (JabRef#4712)
5e34eb1 Update animal-welfare.csl (JabRef#4713)
06785fa Update le-tapuscrit-author-date.csl (JabRef#4708)
ada5282 Update norois.csl (JabRef#4707)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: 906cd6d
github-actions bot pushed a commit to dextep/jabref that referenced this pull request May 1, 2020
Squashed 'src/main/resources/csl-styles/' changes from 143464e..906cd6d
2a00aa3 
906cd6d Create technische-universitat-dresden-linguistik-author-date (JabRef#4730)
607a056 Create ifao-publications.csl (JabRef#4731)
5a65f50 remove et-al settings for bibliography for PVS (JabRef#4735)
4a145d4 Create current-opinion-in-endocrinology-diabetes-and-obesity.csl (JabRef#4734)
d70c2a4 Add chapter section in bibliography (JabRef#4732)
366dbc1 Create economic-history-review.csl (JabRef#4643)
7069ddc Create the-open-university-harvard-s390-modules.csl (JabRef#4711)
a789973 Chicago: Uppercase "Presentated at" if no `genre` (JabRef#4729)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: 906cd6d
github-actions bot pushed a commit to ShikunXiong/jabref that referenced this pull request May 1, 2020
Squashed 'src/main/resources/csl-styles/' changes from c1793d2..906cd6d
b3948d3 
906cd6d Create technische-universitat-dresden-linguistik-author-date (JabRef#4730)
607a056 Create ifao-publications.csl (JabRef#4731)
5a65f50 remove et-al settings for bibliography for PVS (JabRef#4735)
4a145d4 Create current-opinion-in-endocrinology-diabetes-and-obesity.csl (JabRef#4734)
d70c2a4 Add chapter section in bibliography (JabRef#4732)
366dbc1 Create economic-history-review.csl (JabRef#4643)
7069ddc Create the-open-university-harvard-s390-modules.csl (JabRef#4711)
a789973 Chicago: Uppercase "Presentated at" if no `genre` (JabRef#4729)
143464e Fix comma before et al. for the-oncologist.csl (JabRef#4724)
3b331b6 fixed bug with "near-note" position univ.-bordeaux-ecole-doctorale-de… (JabRef#4719)
b2c0c1e APA: in-text title in title-case (JabRef#4725)
88c68d2 Fix et-al and indetation settings for mammalia.csl (JabRef#4717)
05940a2 Update the-febs-journal.csl (JabRef#4720)
1d77ba8 Request for review and assessment of the repa.csl (JabRef#4698)
76b4be5 Update isnad.csl (JabRef#4716)
f709c84 Update isnad-dipnotlu.csl (JabRef#4715)
45d7655 Create mammalia.csl (JabRef#4714)
eb333ca Update society-for-american-archaeology.csl (JabRef#4710)
d944e71 Update masarykova-univerzita-pravnicka-fakulta.csl (JabRef#4712)
5e34eb1 Update animal-welfare.csl (JabRef#4713)
06785fa Update le-tapuscrit-author-date.csl (JabRef#4708)
ada5282 Update norois.csl (JabRef#4707)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: 906cd6d
github-actions bot pushed a commit to systemoperator/jabref that referenced this pull request May 1, 2020
Squashed 'src/main/resources/csl-styles/' changes from c1793d2..906cd6d
635651b 
906cd6d Create technische-universitat-dresden-linguistik-author-date (JabRef#4730)
607a056 Create ifao-publications.csl (JabRef#4731)
5a65f50 remove et-al settings for bibliography for PVS (JabRef#4735)
4a145d4 Create current-opinion-in-endocrinology-diabetes-and-obesity.csl (JabRef#4734)
d70c2a4 Add chapter section in bibliography (JabRef#4732)
366dbc1 Create economic-history-review.csl (JabRef#4643)
7069ddc Create the-open-university-harvard-s390-modules.csl (JabRef#4711)
a789973 Chicago: Uppercase "Presentated at" if no `genre` (JabRef#4729)
143464e Fix comma before et al. for the-oncologist.csl (JabRef#4724)
3b331b6 fixed bug with "near-note" position univ.-bordeaux-ecole-doctorale-de… (JabRef#4719)
b2c0c1e APA: in-text title in title-case (JabRef#4725)
88c68d2 Fix et-al and indetation settings for mammalia.csl (JabRef#4717)
05940a2 Update the-febs-journal.csl (JabRef#4720)
1d77ba8 Request for review and assessment of the repa.csl (JabRef#4698)
76b4be5 Update isnad.csl (JabRef#4716)
f709c84 Update isnad-dipnotlu.csl (JabRef#4715)
45d7655 Create mammalia.csl (JabRef#4714)
eb333ca Update society-for-american-archaeology.csl (JabRef#4710)
d944e71 Update masarykova-univerzita-pravnicka-fakulta.csl (JabRef#4712)
5e34eb1 Update animal-welfare.csl (JabRef#4713)
06785fa Update le-tapuscrit-author-date.csl (JabRef#4708)
ada5282 Update norois.csl (JabRef#4707)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: 906cd6d
dextep pushed a commit to dextep/jabref that referenced this pull request May 8, 2020
@dextep
Squashed 'src/main/resources/csl-styles/' changes from 143464e..906cd6d
0a6ac4d 
906cd6d Create technische-universitat-dresden-linguistik-author-date (JabRef#4730)
607a056 Create ifao-publications.csl (JabRef#4731)
5a65f50 remove et-al settings for bibliography for PVS (JabRef#4735)
4a145d4 Create current-opinion-in-endocrinology-diabetes-and-obesity.csl (JabRef#4734)
d70c2a4 Add chapter section in bibliography (JabRef#4732)
366dbc1 Create economic-history-review.csl (JabRef#4643)
7069ddc Create the-open-university-harvard-s390-modules.csl (JabRef#4711)
a789973 Chicago: Uppercase "Presentated at" if no `genre` (JabRef#4729)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: 906cd6d
dextep pushed a commit to dextep/jabref that referenced this pull request May 8, 2020
@dextep
Squashed 'src/main/resources/csl-styles/' changes from 143464e..906cd6d
d68d044 
906cd6d Create technische-universitat-dresden-linguistik-author-date (JabRef#4730)
607a056 Create ifao-publications.csl (JabRef#4731)
5a65f50 remove et-al settings for bibliography for PVS (JabRef#4735)
4a145d4 Create current-opinion-in-endocrinology-diabetes-and-obesity.csl (JabRef#4734)
d70c2a4 Add chapter section in bibliography (JabRef#4732)
366dbc1 Create economic-history-review.csl (JabRef#4643)
7069ddc Create the-open-university-harvard-s390-modules.csl (JabRef#4711)
a789973 Chicago: Uppercase "Presentated at" if no `genre` (JabRef#4729)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: 906cd6d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tobiasdiez @Siedlerchr