Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added new keyboard shortcut "ctrl+E" for closing the entry editor. (#4222) #4338

Merged
merged 1 commit into from
Sep 13, 2018
Merged

Added new keyboard shortcut "ctrl+E" for closing the entry editor. (#4222) #4338

merged 1 commit into from
Sep 13, 2018

Conversation

razvan05
Copy link
Contributor

@razvan05 razvan05 commented Sep 12, 2018 •
edited by Siedlerchr
Loading

Enhancement presented here [
Fixes #4222
I have added a new keyboard shortcut for closing the entry editor by using "Ctrl+E".

  • Change in CHANGELOG.md described
  • Tests created for changes
  • Manually tested changed features in running JabRef
  • Screenshots added in PR description (for bigger UI changes)
  • Ensured that the git commit message is a good one
  • Check documentation status (Issue created for outdated help page at help.jabref.org?)

tobiasdiez
tobiasdiez approved these changes Sep 12, 2018
View reviewed changes
Copy link
Member

@tobiasdiez tobiasdiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. Everything looks fine to me!

@razvan05
Copy link
Contributor Author

Thank you! First time here.

@Siedlerchr
Copy link
Member

Thanks for your contribution! 👍 Looks good to me as well!
We hope you are interested in contributiong some more.

@Siedlerchr Siedlerchr merged commit a47e826 into JabRef:master Sep 13, 2018
Siedlerchr added a commit that referenced this pull request Sep 13, 2018
@Siedlerchr
Merge remote-tracking branch 'upstream/master' into storeColumnSortOrder
3f28f72 
* upstream/master:
  Fix export of corporate author to MSOffice (#4337)
  Added new keyboard shortcut "ctrl+E" for closing the entry editor. (#4222) (#4338)
  Remove GlobalFocusListener and old TextField entry editor (#4336)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobiasdiez tobiasdiez tobiasdiez approved these changes

@Siedlerchr Siedlerchr Siedlerchr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@razvan05 @Siedlerchr @tobiasdiez