Fix issue 3861 : XMP Dialog, Add new Groups dialog, Append Library dialog to javafx #4264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
Siedlerchr
changed the title
|
I went over everything and think this is now ok so (it's not perfect, but at least workable...). |
tobiasdiez
added
the
status: ready-for-review
Siedlerchr
reviewed
Oct 1, 2018
| @@ -116,49 +110,49 @@ private void writeXMP() { | |||
| .map(Optional::get) | |||
| .collect(Collectors.toList()); | |||
|
|
|||
| SwingUtilities.invokeLater(() -> optionsDialog.getProgressArea() | |||
| .append(entry.getCiteKeyOptional().orElse(Localization.lang("undefined")) + "\n")); | |||
| Platform.runLater(() -> optionsDialog.getProgressArea() | |||
There was a problem hiding this comment.
Shouldn't this already on the FX thread by defintion?
There was a problem hiding this comment.
No, writeXMP is invoked as a background task (but not properly implemented as BackgroundTask, leading to these ugly workaround - but I didnt have the motivation to implement it properly).
Siedlerchr
added a commit
that referenced
this pull request
Oct 13, 2018
* upstream/master: Update Libraries (#4366) ArXiv fetcher support http url (#4367) Fix issue 3861 : XMP Dialog, Add new Groups dialog, Append Library dialog to javafx (#4264) fix IndexOutOfBoundsException when saving preferences group RadioButtons in ExportSortingPrefsTab to prevent the selection of multiple or no order types Convert Part of the Issue#3861 Quality->Cleanup entries (#4268) UPDATE gradle to 4.10.2 (#4358) Completed General Fields Customizer conversion to JavaFX (#4346) Fix JavaFX thread exception when fetching new infos (#4354) Auto trim url field (#4355) Fix freezes in entry editor (#4351) # Conflicts: # src/main/java/org/jabref/preferences/PreferencesService.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tools -> Writing XMP Data to Entry
Groups -> Add new Group
Import->Append Library Dialog