Update Architecture Tests to catch static imports #3766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lenhard
added
status: ready-for-review
Siedlerchr
approved these changes
Feb 23, 2018
| @@ -104,8 +105,7 @@ public void firstPackageIsIndependentOfSecondPackage(String firstPackage, String | |||
| }) | |||
| .collect(Collectors.toList()); | |||
|
|
|||
| Assert.assertEquals("The following classes are not allowed to depend on " + secondPackage, | |||
| Collections.emptyList(), files); | |||
| Assertions.assertEquals(Collections.emptyList(), files, "The following classes are not allowed to depend on " + secondPackage); | |||
There was a problem hiding this comment.
I would prefer a static import of asset und
Siedlerchr
added a commit
that referenced
this pull request
Feb 24, 2018
* upstream/master: (94 commits) Add missing localization for Any file Refactor dublin core utility (#3756) Add Localization Update Architecture Tests to catch static imports (#3766) Added <any file type> to the Import File Filter Dialog. Don't trim when migrating review field (#3761) Reorder again Rename confirmation into "Merge fields" Fix logic Reorder checklist in PR template and add "good commit message" Replace x11 by unity7 Include desktop, desktop-legacy, wayland in snapcraft.yaml Improve Dublin Core (#3710) Incorporate suggestions by @Siedlerchr Update JUnit from 5.1.0-M2 -> 5.1.0 Update Mockito from 2.13.0 -> 2.15.0 Update wiremock from 2.14.0 -> 2.15.0 Fix exceptions for jacoco update gradle Add link to contribute.jabref.org (#3748) ... # Conflicts: # src/main/java/org/jabref/gui/JabRefFrame.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a part of #2617
Updates the architecture tests to JUnit5 and also catches violations in static imports now. I tested this by adding a static import and checking that the build breaks. It does, but of course I had to remove the cause again.