Integrated key word handling in BibtexEntry #375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscargus
force-pushed
the
keywordsinentry
branch
from
325bfe7 to
beb8e96
Compare
| sb.append(", "); | ||
| } | ||
| sb.delete(sb.length() - 2, sb.length()); | ||
| newValue = sb.toString(); |
There was a problem hiding this comment.
String.join(", ", keywords) should do the same as these lines.
oscargus
force-pushed
the
keywordsinentry
branch
3 times, most recently
from
9de5da8 to
9633a87
Compare
| * | ||
| * @param keywords Keywords to add | ||
| */ | ||
| public void addKeywords(ArrayList<String> keywords) { |
There was a problem hiding this comment.
Use List (the abstraction) instead
|
I think this is valuable. If you have time and improve it a little bit plus rebase on master, I think we can merge this in. |
|
I'll do that. Maybe tonight, but cannot promise anything. There are indeed only minor things. I'll wait with the KeyWords class, but I think it makes sense in the long term to have a separate class to deal with this. There may also eventually be something similar for linking entries, but I will need to think more carefully about that... |
…ringUtil to correct file.
…responding tests)
oscargus
force-pushed
the
keywordsinentry
branch
from
9633a87 to
467491c
Compare
|
Might be good to go now. |
simonharrer
added a commit
that referenced
this pull request
Nov 27, 2015
Integrated key word handling in BibtexEntry
u7500248
added a commit
to u7500248/jabref
that referenced
this pull request
Nov 3, 2023
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 10, 2023
* task: first cut of Scite tab and associated preference * task: comments and minor refactoring * task: Updated readme.md for issue #375 * fix: Import ordering and markdown space * fix: imports and whitespace (checkstyle) * fix: imports and whitespace (checkstyle) * fix: imports and whitespace (checkstyle) * fix: Removed unnecessary parentheses (OpenRewrite) * fix: Unit tests and localisation keys * fix: Removed unnecessary heading in CHANGELOG.md * fix: Made SciteTallyDTO a record type and moved it to new file * fix: Made the scite.ai base url a constant * fix: Exception handling now catches most specific exceptions, and rethrows them as FetcherException * fix: style for scite message box * fix: Catch specific exception and display error message rather than throwing a generic unchecked exception * fix: Localization for SciteTab error messages, and "Scite" name is no longer localized * some small refactoring * checkstyle and rename * Update CHANGELOG.md * Update EntryEditorTab.java * move and checkstyle * fix l10n and rename --------- Co-authored-by: Siedlerchr <[email protected]> Co-authored-by: Carl Christian Snethlage <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved the key word handling to BibtexEntry.
Added new methods addKeyword and addKeywords to simply add one or more keywords. Will be useful when merging key words later on.