-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed issue 298 #3726
fixed issue 298 #3726
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please change the capitalization in the changelog to proper English sentence case. Apart from this, +1 for merge.
For future PRs you should specify a short title describing the content of the PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution. For the record, this is the issue we are talking about: JabRef#298
Next time, just use the link so that github can make the connection.
I am merging now.
After merging, I realized that this PR did not build on master. The branch this built on will eventually also be merged into master, which will get the change in. Nevertheless, with an issue like this there is no reason to base on a branch different from master. Next time, please make sure that you base on master. |
The changelog should be
No space and Nevertheless thank you for the quick action taken @grotepfn. Hope to see another issue fixed. |
fixed issue 298
Credit (for an exercise):
Florian Grotepaß