[WIP] Django style unchained.

[tobiasdiez]

Code examples are better than words. So, let them speak. Instead of the current

super.getFoo()
        .foo()
        .getBar()
        .bar();

we now get the nicely aligned

super.getFoo()
     .foo()
     .getBar()
     .bar();

---

• Change in CHANGELOG.md described
• Tests created for changes
• Screenshots added (for bigger UI changes)
• Manually tested changed features in running JabRef
• Check documentation status (Issue created for outdated help page at help.jabref.org?)

[Siedlerchr]

Good! Now we just need the same for the Eclipse style.

[lenhard]

Code examples may be better than words, but only if they are really really obvious ;-) To be honest, I don't get why the new style is strictly better. I have nothing against it, but I also don't see any obvious benefit. To me, it just doesn't matter.

Could you convince me with words?

[tobiasdiez]

Well, there are of course no real benefits. We will not perform 200% more efficient because of this change. It's just a matter of taste and for me fluent code (with builders or the stream api) does not look "nice". But of course this is a subjective opinion. For example, why is map indented (with respect to getValues) but collect is on the same level as map? It just feels unlogical.

return field.getValues().stream()
                .map(SpecialFieldValueViewModel::new)
                .collect(Collectors.toList());

The reformatted

return field.getValues().stream()
            .map(SpecialFieldValueViewModel::new)
            .collect(Collectors.toList());

is easier to read and to "parse" in my opinion. Get values, map them, collect. Finish.

[lenhard]

Ok, I am buying into that :-) Could we do the same configuration for Eclipse here as well (as requested by @Siedlerchr ). Just to ensure that there is no constant reformatting of the code with different IDEs.

[Siedlerchr]

https://stackoverflow.com/questions/6275785/wrapping-chained-method-calls-on-a-separate-line-in-eclipse-for-java
will try to check that the next days