Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Library properties: no change but.. (issue #3562) #3579

Merged
merged 6 commits into from
Dec 31, 2017
Merged

Library properties: no change but.. (issue #3562) #3579

merged 6 commits into from
Dec 31, 2017

Conversation

PJozeph
Copy link
Contributor

@PJozeph PJozeph commented Dec 25, 2017 •
edited by Siedlerchr
Loading

When user wanted to lead default Library properties, after clicking OK button even though there was no modification in Library property the bibTeX tab marked as modified. I fixed this bug so no need to worry about this anymore.

Fixes #3562

  • Change in CHANGELOG.md described
  • Tests created for changes
  • Screenshots added (for bigger UI changes)
  • Manually tested changed features in running JabRef
  • Check documentation status (Issue created for outdated help page at help.jabref.org?)
  • If you changed the localization: Did you run gradle localizationUpdate?

Siedlerchr
Siedlerchr reviewed Dec 25, 2017
View reviewed changes
src/main/java/org/jabref/gui/dbproperties/DatabasePropertiesDialog.java Outdated
return changed;
}

private boolean newAndOldOrderCinfigIsSame(SaveOrderConfig newSaveOrderConfig, SaveOrderConfig oldSaveOrderConfig) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like a typo here -> cinfig -> Config

Siedlerchr
Siedlerchr approved these changes Dec 25, 2017
View reviewed changes
Copy link
Member

@Siedlerchr Siedlerchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested your changes locally and it works.

@Siedlerchr Siedlerchr added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Dec 27, 2017
@Siedlerchr
Copy link
Member

@JabRef/developers A second review needs to be done

tobiasdiez
tobiasdiez requested changes Dec 29, 2017
View reviewed changes
Copy link
Member

@tobiasdiez tobiasdiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a very minor remark and then we can merge this.

src/main/java/org/jabref/gui/dbproperties/DatabasePropertiesDialog.java Outdated
}

private boolean newAndOldOrderConfigIsSame(SaveOrderConfig newSaveOrderConfig, SaveOrderConfig oldSaveOrderConfig) {
return newSaveOrderConfig.equals(oldSaveOrderConfig) ? false : true;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is equivalent to !newSaveOrderConfig.equals(oldSaveOrderConfig), right? In this case you can also directly inline this code.

@tobiasdiez tobiasdiez merged commit 504f7d8 into JabRef:master Dec 31, 2017
@tobiasdiez
Copy link
Member

@PJozeph Thanks for the quick follow-up and a Happy New Year!

Siedlerchr added a commit that referenced this pull request Jan 2, 2018
@Siedlerchr
Merge remote-tracking branch 'upstream/master' into selectFilesDlg
d4aed9b 
* upstream/master:
  Remove dependency to jgoodies-looks (#3458)
  Add simple gui test (#3399)
  Library properties: no change but.. (issue #3562) (#3579)
  Initialize previe before MainPanel to prevent NPEs on delete Fixes #3584
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobiasdiez tobiasdiez tobiasdiez requested changes

@Siedlerchr Siedlerchr Siedlerchr approved these changes

Assignees
No one assigned
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Library properties: no change but...
3 participants
@PJozeph @Siedlerchr @tobiasdiez