-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new authors to mailMap #3567
Conversation
Domenico Cufalo <[email protected]> | ||
Tobias Bouschen <[email protected]> | ||
József Pallagi <[email protected]> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now new line at eof? is this correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes? Is there any reason against this?
.mailmap
Outdated
@@ -90,9 +90,9 @@ Ulrik Stervbo <[email protected]> | |||
Stefano Gariazzo <[email protected]> | |||
Lee Patton <[email protected]> | |||
Jörg Lenhard <[email protected]> | |||
<[email protected]> <[email protected]> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please do not change this to the real name.
The intention is to map all different email addresses of one user to a single email address. The reason for that is that tools might have name + email or even the email only as unique key for code analysis. When having different emails, users might be treated as separate users.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay, the problem is just, that now if I run the generate-authors
script a new name Joerg Lenhard
appears. How can I do that properly?
Then add the Name in front additionally:
name mail mail
Am 22.12.2017 19:19 schrieb "Linus Dietz" <[email protected]>:
… ***@***.**** commented on this pull request.
------------------------------
In .mailmap
<#3567 (comment)>:
> @@ -90,9 +90,9 @@ Ulrik Stervbo ***@***.***>
Stefano Gariazzo ***@***.***>
Lee Patton ***@***.***>
Jörg Lenhard ***@***.***>
***@***.***> ***@***.***>
okay, the problem is just, that now if I run the generate-authors script
a new name Joerg Lenhard appears. How can I do that properly?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#3567 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABTafo_s2PD9MlRNuOLJQD0FDKTDDXQoks5tC_KcgaJpZM4RK-_x>
.
|
* upstream/master: (121 commits) Fix fetcher tests (#3583) Convert entry preview panel to JavaFX (#3574) Remove dependency for JUnit4 (#3580) Update tracis cache config as recommned by the docs (#3575) fix typo Show development information Release v4.1 Add new authors to mailMap (#3567) Fix build Really fix changelog Fix changelog Minor changes Disable the autocompletion as default (#3569) Add update exception for applicationinsights 2.0.0-BETA (#3571) Install4j jres 152 (#3570) Fix grammar mistake Downgrade applicationinsights. Fixes #3561 Adapt scripts/prepare-install4j.sh to JRE1.8.0_152 (#3568) ExportFormats: Use FileExtension enum (#3565) Update guava from 23.5-jre -> 23.6-jre ... # Conflicts: # build.gradle
* upstream/master: (234 commits) Fix checkstyle Fix tests Fix fetcher tests (#3583) Convert entry preview panel to JavaFX (#3574) Remove dependency for JUnit4 (#3580) Update tracis cache config as recommned by the docs (#3575) fix typo Show development information Release v4.1 Add new authors to mailMap (#3567) Fix build Really fix changelog Fix changelog Minor changes Disable the autocompletion as default (#3569) Add update exception for applicationinsights 2.0.0-BETA (#3571) Install4j jres 152 (#3570) Fix grammar mistake Downgrade applicationinsights. Fixes #3561 Adapt scripts/prepare-install4j.sh to JRE1.8.0_152 (#3568) ...
These are the new authors of Jabref. 🎉
I have contacted @MBunel and @weidafan, whether they can provide us their full names, so let's wait until the release before we merge this.