Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add required lib for junit5 in eclipse #3495

Merged
merged 1 commit into from
Dec 8, 2017
Merged

Add required lib for junit5 in eclipse #3495

merged 1 commit into from
Dec 8, 2017

Conversation

Siedlerchr
Copy link
Member

@Siedlerchr Siedlerchr commented Dec 7, 2017 •
edited
Loading

This enables working junit5 with eclipse Oxygen
https://marketplace.eclipse.org/content/junit-5-support-oxygen

  • Change in CHANGELOG.md described
  • Tests created for changes
  • Screenshots added (for bigger UI changes)
  • Manually tested changed features in running JabRef
  • Check documentation status (Issue created for outdated help page at help.jabref.org?)
  • If you changed the localization: Did you run gradle localizationUpdate?

@Siedlerchr Siedlerchr added dev: build-system status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers labels Dec 7, 2017
@Siedlerchr Siedlerchr merged commit 26f38b2 into master Dec 8, 2017
@Siedlerchr Siedlerchr deleted the junit5 branch December 8, 2017 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobiasdiez tobiasdiez tobiasdiez approved these changes

Assignees
No one assigned
Labels
dev: build-system status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Siedlerchr @tobiasdiez