Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add drag and drop support for files in General Tab #3200

Merged
merged 2 commits into from
Sep 7, 2017
Merged

Add drag and drop support for files in General Tab #3200

merged 2 commits into from
Sep 7, 2017

Conversation

Siedlerchr
Copy link
Member

@Siedlerchr Siedlerchr commented Sep 6, 2017 •
edited
Loading

Implements JabRef#244

  • Change in CHANGELOG.md described
  • Tests created for changes
  • Screenshots added (for bigger UI changes)
  • Manually tested changed features in running JabRef
  • Check documentation status (Issue created for outdated help page at help.jabref.org?)
  • If you changed the localization: Did you run gradle localizationUpdate?

@Siedlerchr
Copy link
Member Author

Siedlerchr commented Sep 6, 2017 •
edited
Loading

TODO: show attach file dialog
//Edit: I tried to this, but I am getting problems with swing/javafx threading which I can't solve.
So I would postpone this

@Siedlerchr Siedlerchr added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Sep 6, 2017
@koppor
Copy link
Member

koppor commented Sep 6, 2017 •
edited
Loading

Tried out locally. It works.

The dialog missing is the following one:

grafik

@koppor koppor mentioned this pull request Sep 6, 2017
Closed
@koppor koppor added this to the v4.0 milestone Sep 7, 2017
lenhard
lenhard approved these changes Sep 7, 2017
View reviewed changes
Copy link
Member

@lenhard lenhard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it locally (works) and the code looks fine.

If @koppor really wants to have it in 4.0 (despite the missing dialog) then I have no problem with that. To fully solve this, the dialog probably needs to be migrated to JavaFX.

@koppor koppor merged commit 753dbaa into master Sep 7, 2017
@koppor koppor deleted the dropAttachFile branch September 7, 2017 08:21
@koppor
Copy link
Member

koppor commented Sep 7, 2017

I'd like to offer as much as possible functionality of 3.8.2. 😇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lenhard lenhard lenhard approved these changes

@koppor koppor koppor approved these changes

Assignees
No one assigned
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Milestone
v4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Siedlerchr @koppor @lenhard