Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

syncLang.py: link in markdown output #3179

Merged
merged 1 commit into from
Sep 1, 2017
Merged

syncLang.py: link in markdown output #3179

merged 1 commit into from
Sep 1, 2017

Conversation

mlep
Copy link
Contributor

@mlep mlep commented Aug 31, 2017

To allow for a more direct edit of the localization files.

Please, triple check, I am in no way a python programmer.

  • Change in CHANGELOG.md described
  • Tests created for changes
  • Screenshots added (for bigger UI changes)
  • Manually tested changed features in running JabRef
  • Check documentation status (Issue created for outdated help page at help.jabref.org?)
  • If you changed the localization: Did you run gradle localizationUpdate?

Copy link
Member

@Siedlerchr Siedlerchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, have not yet tried it

@koppor
Copy link
Member

koppor commented Sep 1, 2017

Tried id out locally - and it works. Thank you for the PR!

@koppor koppor merged commit 9ffcb69 into JabRef:master Sep 1, 2017
@LinusDietz
Copy link
Member

as a follow up: I have tested it as well, works.

What about automatically generating this data with each push to master and publish a html version on jabref.org?

@mlep
Copy link
Contributor Author

mlep commented Sep 1, 2017

It would be nice!

@mlep
Copy link
Contributor Author

mlep commented Sep 1, 2017

Although: it would be nice if the order of the languages would be always the same.

@LinusDietz
Copy link
Member

That should be feasible. Is that all the requirements you can think of? I would volunteer to program that. Would you be so kind to file an issue to separate the discussion and point out all potential requirements?

@mlep mlep mentioned this pull request Sep 1, 2017
@mlep
Copy link
Contributor Author

mlep commented Sep 1, 2017

Done (Issue #3181)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants