Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix group freeze by running markBasechange in swing thread #3058

Merged
merged 2 commits into from
Jul 30, 2017
Merged

Fix group freeze by running markBasechange in swing thread #3058

merged 2 commits into from
Jul 30, 2017

Conversation

Siedlerchr
Copy link
Member

@Siedlerchr Siedlerchr commented Jul 30, 2017 •
edited
Loading

This fixes #3036

I debugged a bit and found that this was a threading problem. When assiging an entry to a group, the markBaseChanged was executed in the JavaFX Thread and not in the Swing thread.

  • Change in CHANGELOG.md described
  • Tests created for changes
  • Screenshots added (for bigger UI changes)
  • Manually tested changed features in running JabRef
  • Check documentation status (Issue created for outdated help page at help.jabref.org?)
  • If you changed the localization: Did you run gradle localizationUpdate?

@Siedlerchr Siedlerchr requested a review from lenhard July 30, 2017 10:20
@Siedlerchr Siedlerchr mentioned this pull request Jul 30, 2017
Closed
@Siedlerchr Siedlerchr added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Jul 30, 2017
matthiasgeiger
matthiasgeiger approved these changes Jul 30, 2017
View reviewed changes
Copy link
Member

@matthiasgeiger matthiasgeiger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - and fixes at least the grouping bug.

@matthiasgeiger matthiasgeiger merged commit 81e6e8e into master Jul 30, 2017
@matthiasgeiger matthiasgeiger deleted the fixGroupFreez branch July 30, 2017 19:17
@matthiasgeiger matthiasgeiger mentioned this pull request Jul 31, 2017
Closed
Siedlerchr added a commit that referenced this pull request Jul 31, 2017
@Siedlerchr
Merge remote-tracking branch 'upstream/master' into selectFilesDlg
b6d43dc 
* upstream/master: (41 commits)
  update xmlunit from 2.3.0 -> 2.4.0
  update wiremock from 2.6.0 -> 2.7.0
  update controlsfx from 8.40.12 -> 8.40.13
  Fix group freeze by running markBasechange in swing thread (#3058)
  Localization: French: translation of new entries (#3050)
  Fix ads fetcher (#3048)
  Update translation (#3041)
  Translate new strings (#3040)
  Fix navigation in entry editor increases modifies font size (#3037)
  Initial idea for architectural decision records (#3033)
  Readd comment
  Readd comment
  Fix keybdining in entry editor in localized installation (#3030)
  Structuring
  Upgrade shadowJar
  Modernizer improvements
  Replace Reimplement MappedList.kt (#3032)
  Use https for the maven ej-technologies repo
  Upgrade modernizer plugin
  Remove separator next to search bar
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobiasdiez tobiasdiez tobiasdiez approved these changes

@matthiasgeiger matthiasgeiger matthiasgeiger approved these changes

@lenhard lenhard Awaiting requested review from lenhard

Assignees
No one assigned
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Jabref freezes when dragging entries to groups panel or moving entries within groups
3 participants
@Siedlerchr @matthiasgeiger @tobiasdiez