-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace Reimplement MappedList.kt #3032
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,113 @@ | ||
package org.jabref.gui.util; | ||
|
||
import java.util.ArrayList; | ||
import java.util.List; | ||
import java.util.function.Function; | ||
|
||
import javafx.collections.ListChangeListener; | ||
import javafx.collections.ObservableList; | ||
import javafx.collections.transformation.TransformationList; | ||
|
||
/** | ||
* MappedList implementation based on https://gist.github.com/TomasMikula/8883719 | ||
* | ||
* @author https://github.com/TomasMikula | ||
*/ | ||
public final class MappedList<A, B> extends TransformationList<A, B> { | ||
|
||
private final Function<B, A> mapper; | ||
|
||
public MappedList(ObservableList<? extends B> sourceList, Function<B, A> mapper) { | ||
super(sourceList); | ||
this.mapper = mapper; | ||
} | ||
|
||
@Override | ||
protected void sourceChanged(ListChangeListener.Change<? extends B> change) { | ||
fireChange(new ListChangeListener.Change<A>(this) { | ||
|
||
@Override | ||
public boolean wasAdded() { | ||
return change.wasAdded(); | ||
} | ||
|
||
@Override | ||
public boolean wasRemoved() { | ||
return change.wasRemoved(); | ||
} | ||
|
||
@Override | ||
public boolean wasReplaced() { | ||
return change.wasReplaced(); | ||
} | ||
|
||
@Override | ||
public boolean wasUpdated() { | ||
return change.wasUpdated(); | ||
} | ||
|
||
@Override | ||
public boolean wasPermutated() { | ||
return change.wasPermutated(); | ||
} | ||
|
||
@Override | ||
public int getPermutation(int index) { | ||
return change.getPermutation(index); | ||
} | ||
|
||
@Override | ||
protected int[] getPermutation() { | ||
// This method is only called by the superclass methods | ||
// wasPermutated() and getPermutation(int), which are | ||
// both overridden by this class. There is no other way | ||
// this method can be called. | ||
throw new AssertionError("Unreachable code"); | ||
} | ||
|
||
@Override | ||
public List<A> getRemoved() { | ||
List<A> result = new ArrayList<>(change.getRemovedSize()); | ||
for (B element : change.getRemoved()) { | ||
result.add(mapper.apply(element)); | ||
} | ||
return result; | ||
} | ||
|
||
@Override | ||
public int getFrom() { | ||
return change.getFrom(); | ||
} | ||
|
||
@Override | ||
public int getTo() { | ||
return change.getTo(); | ||
} | ||
|
||
@Override | ||
public boolean next() { | ||
return change.next(); | ||
} | ||
|
||
@Override | ||
public void reset() { | ||
change.reset(); | ||
} | ||
}); | ||
} | ||
|
||
@Override | ||
public int getSourceIndex(int index) { | ||
return index; | ||
} | ||
|
||
@Override | ||
public A get(int index) { | ||
return mapper.apply(super.getSource().get(index)); | ||
} | ||
|
||
@Override | ||
public int size() { | ||
return super.getSource().size(); | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This implementation of the MappedList looks identical to the one in the EasyBind package but is different from
MappedList.kt
.The mapped list from the corda package runs the
mapper
when the item is inserted/updated while this implementation here invokes themapper
on everyget
-call. Since theget
method is called relatively often (e.g. if you scroll in the listview), the EasyBind implementation should only be used for quick mappers. Can you please revert the change and/or write a direct reimplementation of the corda mapped list since we otherwise run again in performance problems with huge groups trees.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, will do!