Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimize depdencies fetched by using net.corda:jfx #3017

Merged
merged 1 commit into from
Jul 16, 2017

Conversation

koppor
Copy link
Member

@koppor koppor commented Jul 15, 2017

This is to reduce the mass of transitive dependencies fetched by using corda.net. See #3014.

  • Change in CHANGELOG.md described
  • Tests created for changes
  • Screenshots added (for bigger UI changes)
  • Manually tested changed features in running JabRef
  • Check documentation status (Issue created for outdated help page at help.jabref.org?)
  • If you changed the localization: Did you run gradle localizationUpdate?

@koppor koppor added type: code-quality Issues related to code or architecture decisions status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers labels Jul 15, 2017
Copy link
Member

@Siedlerchr Siedlerchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a workaround, I think we just should convert the list class

@lenhard
Copy link
Member

lenhard commented Jul 15, 2017

The conversion would be the more desirable solution.

But if we don't get the conversion done before the release of 4.0, we might consider to merge it anyway. I'd say: Let's keep this PR open until either someone does the conversion or we want to release 4.0.

@koppor
Copy link
Member Author

koppor commented Jul 16, 2017

I assigned #3014 to a milestone, so we are reminded that there is some work left.

I will merge this in as it will surely reduce the size of our JAR.

@koppor koppor merged commit 4c805ef into master Jul 16, 2017
@koppor koppor deleted the minimize-net-corda-depedency branch July 16, 2017 08:10
Siedlerchr added a commit that referenced this pull request Jul 16, 2017
* upstream/master:
  Minimize depdencies fetched by using net.corda:jfx (#3017)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers type: code-quality Issues related to code or architecture decisions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants