Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix exception when no citekey is present #2904

Merged
merged 2 commits into from
Jun 11, 2017
Merged

Fix exception when no citekey is present #2904

merged 2 commits into from
Jun 11, 2017

Conversation

Siedlerchr
Copy link
Member

@Siedlerchr Siedlerchr commented Jun 11, 2017 •
edited
Loading

Fix #2903

  • Change in CHANGELOG.md described
  • Tests created for changes
  • Screenshots added (for bigger UI changes)
  • Manually tested changed features in running JabRef
  • Check documentation status (Issue created for outdated help page at help.jabref.org?)
  • If you changed the localization: Did you run gradle localizationUpdate?

@Siedlerchr Siedlerchr added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Jun 11, 2017
LinusDietz
LinusDietz approved these changes Jun 11, 2017
View reviewed changes
Copy link
Member

@LinusDietz LinusDietz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good!

@LinusDietz LinusDietz merged commit c711a7f into master Jun 11, 2017
@LinusDietz LinusDietz deleted the fixFileAnnoationTab branch June 11, 2017 19:51
Siedlerchr added a commit that referenced this pull request Jun 12, 2017
@Siedlerchr
Merge remote-tracking branch 'upstream/master' into sharelatex
373a5be 
* upstream/master:
  Fix exception when no citekey is present (#2904)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LinusDietz LinusDietz LinusDietz approved these changes

Assignees
No one assigned
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Siedlerchr @LinusDietz