Adsurl to url #2861
Merged
Adsurl to url #2861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Siedlerchr
approved these changes
May 23, 2017
|
Thank you very much for your contribution. From my side the code looks good. When another dev gives his okay, we can merge it |
|
Is there a test added?
Am 23.05.2017 09:01 schrieb "Christoph" <[email protected]>:
… Thank you very much for your contribution. From my side the code looks
good. When another dev gives his okay, we can merge it
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#2861 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABTafkwGo_YOJ-ZuphhmQfvT-_lGQq73ks5r8pJzgaJpZM4NjSqx>
.
|
tobiasdiez
requested changes
May 23, 2017
| new FieldFormatterCleanup("adsnote", new ClearFormatter()).cleanup(entry); | ||
| new FieldFormatterCleanup("adsurl", new ClearFormatter()).cleanup(entry); | ||
| // Move adsurl to url field | ||
| new MoveFieldCleanup("adsurl","url").cleanup(entry); |
There was a problem hiding this comment.
Can you please use FieldName.URL instead of "url". Moreover, add a space after the comma.
There was a problem hiding this comment.
@tobiasdiez I've revised the file as you commented. Thanks for your comment-
stefan-kolb
approved these changes
May 23, 2017
use FieldName.URL instead of "url" as commented by @tobiasdiez
|
@koppor Do you mean the stuff under build/test-results/test/ directory? (created after running |
|
I'd like to take this opportunity to thank all the JabRef developers for their excellent jobs. JabRef is getting wonderful and wonderful! The contribution guide is clear and easy to follow as well. I'm a newbie in Java coding and github things, but I didn't have much trouble. I'm happy I was able to make some contribution. |
Siedlerchr
added a commit
that referenced
this pull request
May 27, 2017
* upstream/master: (23 commits) Implement #2785: resort groups using drag & drop (#2864) Add Library of Congress as ID-fetcher (#2865) Fix export and import of MS office day/year/month acessed fields (#2862) Adsurl to url (#2861) Update LICENSE.md Update Update LICENSE.md Update license file so that github recognize it properly Improve Issue Template Using a Collapsible Log Area Fix #2852: Improve performance of group filtering. Rename GroupSelector to GroupSidePane Fix #2843: Show information correctly in entry editor Remove old entry editor code related to focus selection Implement feedback Menu Greek Translation (#2836) Relaxed the regex to also match negative timezone formats when parsing pdf annotation dates (#2841) Update localization Remove unnecessary group code (and move remaining settings to preferences) Add Local Maven repo as first lookup resource, to avoid having duplicate libs in gradle and maven Implement #2786: Allow selection of multiple groups ...
Siedlerchr
added a commit
that referenced
this pull request
Jun 3, 2017
* upstream/master: (38 commits) Add link to "feature branch workflow" Support Annotations Created by Foxit (#2878) Fixes jacoco by excluding the fetcher tests from analysis (#2877) Fix entry editor (#2875) update bcprov-jdk15on from 1.56 -> 1.57 update assertj-swing-junit from 3.5.0 -> 3.6.0 update mockito-core from 2.7.22 -> 2.8.9 update jfx from 0.11.0 -> 0.11.1 update google guava from 21.0 -> 22.0 Fix Divide by zero exception if rows is zero in Entry Editor Tab (#2873) Implement #2785: resort groups using drag & drop (#2864) Add Library of Congress as ID-fetcher (#2865) Fix export and import of MS office day/year/month acessed fields (#2862) Adsurl to url (#2861) Update LICENSE.md Update Update LICENSE.md Update license file so that github recognize it properly Improve Issue Template Using a Collapsible Log Area Fix #2852: Improve performance of group filtering. ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the
adsurlfield to theurlfield. The current ADS fetcher removes the fieldadsurl. Theadsurlfield is the only url given by the ADS database to all entry in the database. I think it is better to keep the url information rather than deleting it. It is more profitable when considering the copy command 'Edit - Copy BibTex key and link.' (I have rungradlew checkand there was no problem.)gradle localizationUpdate?