Sauliusg fix 2700 null pointer exception on get fulltext #2751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
'null pointer exception'.
pointer exception' when a databse is opened in a current directory.
re-create the necessary run environment.
also three regression tests for the old functionality.
the previous bug. Indeed, the new unit test fails both in Eclipse and in the CLI './gradlew build' run.
pointer exception' if a database is passed as a local file without explicite path. The tests in 'BibDatabaseContextTest.java' pass again.
'BibDatabaseContextTest'.
BibDatabaseContextTest unit test.
…ps://github.com/sauliusg/jabref into sauliusg-fix-2700-null-pointer-exception-on-Get-fulltext * 'fix-2700-null-pointer-exception-on-Get-fulltext' of https://github.com/sauliusg/jabref: Commenting variables used in the 'BibDatabaseContextTest' unit test. Changing 'assert ...path != null ...' to 'Objects.requireNonNull(...)'. Switcing from 'assertTrue' to 'assertEquals' in the BibDatabaseContextTest unit test. Fixed the coding style according to the JabRef conventions. Adding explicite scope ('private') to 'FileDirectoryPreferences preferences'. Removing the test line that is not needed for the tests to work in 'BibDatabaseContextTest'. Restoring my fix in the 'BibDatabaseContext.java' file, fixing the 'null pointer exception' if a database is passed as a local file without explicite path. The tests in 'BibDatabaseContextTest.java' pass again. Temporarily commenting out of the new fix, to see if the new tests catch the previous bug. Indeed, the new unit test fails both in Eclipse and in the CLI './gradlew build' run. Fixing the order of imports in the newly created test file. Creating a working unit test for the new relative path fix, and adding also three regression tests for the old functionality. Attempting to create a unit test for the new fix, but so far could not re-create the necessary run environment. Adding a fix for the [WIP] Clicking 'Get fulltext' triggers a 'null pointer exception' when a databse is opened in a current directory. Removing the rest of my debug prints. Removing the 'HERE' debug print. Adding a bunch of debug prints and assert's to find a reason for the 'null pointer exception'.
Siedlerchr
added
the
status: ready-for-review
Siedlerchr
deleted the
sauliusg-fix-2700-null-pointer-exception-on-Get-fulltext
branch
Siedlerchr
pushed a commit
that referenced
this pull request
Apr 16, 2017
* Adding a bunch of debug prints and assert's to find a reason for the
'null pointer exception'.
* Removing the 'HERE' debug print.
* Removing the rest of my debug prints.
* Adding a fix for the [WIP] Clicking 'Get fulltext' triggers a 'null
pointer exception' when a databse is opened in a current directory.
* Attempting to create a unit test for the new fix, but so far could not
re-create the necessary run environment.
* Creating a working unit test for the new relative path fix, and adding
also three regression tests for the old functionality.
* Fixing the order of imports in the newly created test file.
* Temporarily commenting out of the new fix, to see if the new tests catch
the previous bug. Indeed, the new unit test fails both in Eclipse and in
the CLI './gradlew build' run.
* Restoring my fix in the 'BibDatabaseContext.java' file, fixing the 'null
pointer exception' if a database is passed as a local file without
explicite path. The tests in 'BibDatabaseContextTest.java' pass again.
* Removing the test line that is not needed for the tests to work in
'BibDatabaseContextTest'.
* Adding explicite scope ('private') to 'FileDirectoryPreferences
preferences'.
* Fixed the coding style according to the JabRef conventions.
* Switcing from 'assertTrue' to 'assertEquals' in the
BibDatabaseContextTest unit test.
* Changing 'assert ...path != null ...' to 'Objects.requireNonNull(...)'.
* Commenting variables used in the 'BibDatabaseContextTest' unit test.
* Fix paths handling in test and mock fileDirPrefs
* Fix modernizer
Siedlerchr
added a commit
that referenced
this pull request
Apr 16, 2017
* 'master' of https://github.com/JabRef/jabref: Sauliusg fix 2700 null pointer exception on get fulltext (#2751)
koppor
pushed a commit
that referenced
this pull request
Apr 16, 2017
* Adding a bunch of debug prints and assert's to find a reason for the
'null pointer exception'.
* Removing the 'HERE' debug print.
* Removing the rest of my debug prints.
* Adding a fix for the [WIP] Clicking 'Get fulltext' triggers a 'null
pointer exception' when a databse is opened in a current directory.
* Attempting to create a unit test for the new fix, but so far could not
re-create the necessary run environment.
* Creating a working unit test for the new relative path fix, and adding
also three regression tests for the old functionality.
* Fixing the order of imports in the newly created test file.
* Temporarily commenting out of the new fix, to see if the new tests catch
the previous bug. Indeed, the new unit test fails both in Eclipse and in
the CLI './gradlew build' run.
* Restoring my fix in the 'BibDatabaseContext.java' file, fixing the 'null
pointer exception' if a database is passed as a local file without
explicite path. The tests in 'BibDatabaseContextTest.java' pass again.
* Removing the test line that is not needed for the tests to work in
'BibDatabaseContextTest'.
* Adding explicite scope ('private') to 'FileDirectoryPreferences
preferences'.
* Fixed the coding style according to the JabRef conventions.
* Switcing from 'assertTrue' to 'assertEquals' in the
BibDatabaseContextTest unit test.
* Changing 'assert ...path != null ...' to 'Objects.requireNonNull(...)'.
* Commenting variables used in the 'BibDatabaseContextTest' unit test.
* Fix paths handling in test and mock fileDirPrefs
* Fix modernizer
Siedlerchr
added a commit
that referenced
this pull request
Apr 19, 2017
* upstream/master: Reorder CHANGELOG for 4.0-beta release Add test that 3.8.2 should not be updated to 4.0-beta Fix test according to new behavior Sauliusg fix 2700 null pointer exception on get fulltext (#2751) Fix selecting all entries with shortcut (#2683) Incoporate feedback. Make it work for one comma (and not for two) Revert "allow search for words without diacritics in contain-based mode". I did not know that the push is considered in my push request allow search for words without diacritics in contain-based mode Update CHANGELOG.md corrected issue #2652
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup from @sauliusg PR #2744
Fix for #2739