Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export single corporate author to ms office xml #2688

Merged
merged 5 commits into from
Mar 30, 2017
Merged

Conversation

Siedlerchr
Copy link
Member

@Siedlerchr Siedlerchr commented Mar 26, 2017

If the author in JabRef is enclosed in curly braces .e.g {JabRef Developers} it is now recognized as corporate author and exported in the corresponding field.
This should also work for editor and other ms office author fields

Refs #1497

  • Change in CHANGELOG.md described
  • Tests created for changes
    - [ ] Screenshots added (for bigger UI changes)
  • Manually tested changed features in running JabRef
  • Check documentation status (Issue created for outdated help page at help.jabref.org?)
    - [] If you changed the localization: Did you run gradle localizationUpdate?

@Siedlerchr Siedlerchr added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Mar 26, 2017
Copy link
Member

@tobiasdiez tobiasdiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code changes look good to me. However, probably it would be good to embed a similar logic in the AuthorList class. By the way, I have no idea why there is a class msbib.PersonName - this looks like a duplicate of Author and should probably replaced by it. Similar the parsing https://github.com/JabRef/jabref/pull/2688/files#diff-22fc42ead754a2997ddf3a14c54fdca5R112 is already handled by AuthorList.parse.

* upstream/master:
  Update mockito from 2.7.18 to 2.7.19
  pin latex2unicode to version 0.2
  Update gradle from 3.3 3.4.1
@Siedlerchr
Copy link
Member Author

@tobiasdiez I now used the Author/Authorlist parsing classes. I created a new class for MsBib which is essentially a wrapper class around the Author class, but handles a few more things only relevant to MS bib.
Checking for corporate authors is not possible inside the Author parser as there are surrounding braces already stripped on calling.

@tobiasdiez
Copy link
Member

Good job! Code looks ok now and only fetcher tests fail -> merge.

@tobiasdiez tobiasdiez merged commit 0c34fa4 into master Mar 30, 2017
@tobiasdiez tobiasdiez deleted the msofficeCorporate branch March 30, 2017 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants