-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix a few group related issues #2361
Conversation
The groups code is a mess :-( Thanks for being willing to put up with this! Unfortunately, the amount of changes is too large for meaningful review and my knowledge on groups and the related code is too limited. I would trust your ability, and the amount of tests that you added here together with the working build. Cosmetic changes can be made on a later occasion. I am sure this is not the last visit to the groups code. Since this is on your private branch, we have no build on builds.jabref.org. If we had, we could ask the people that reported the issues to try out this version. Any chance of getting a build for this? |
<?xml version="1.0" encoding="UTF-8"?> | ||
<Diagram> | ||
<ID>JAVA</ID> | ||
<OriginalElement>net.sf.jabref.model.groups.AbstractGroup</OriginalElement> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not using PlantUML for documenting?
Which tool did you use?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IntelliJ's built-in one
Decision: merge so that many people will be able to test it. We can include code review comments later in a separate PR. I am very aware of the risk. Refs #1495. |
Nothing important or me. Think, this was also happening using the old groups code. |
This PR fixes #2334, #1873 and #1681.
Since I didn't understood the groups code, I also refactored it. Main changes:
KeywordGroup
class intoWordKeywordGroup
, which splits field content into words and then matches them, andRegexKeywordGroup
that uses a regular expression for this job.GroupSerializer
(previously every group decided about its own serialization via thetoString
method)gradle localizationUpdate
?