Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to LGoodDatePicker #2340

Merged
merged 3 commits into from
Dec 5, 2016
Merged

Switch to LGoodDatePicker #2340

merged 3 commits into from
Dec 5, 2016

Conversation

matthiasgeiger
Copy link
Member

see #2176

  • [ ] Change in CHANGELOG.md described should not be relevant
  • [ ] Tests created for changes UI only
  • [ ] Screenshots added (for bigger UI changes)
  • Manually tested changed features in running JabRef
  • [ ] Check documentation status (Issue created for outdated help page at help.jabref.org?)
  • [ ] If you changed the localization: Did you run gradle localizationUpdate?

datePicker.showButtonOnly(true);
datePicker.addActionListener(this);
datePicker.setShowTodayButton(true);
// Create a date picker: With Hidden text field (Showing button only).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hidden and showing (lower case)

@koppor
Copy link
Member

koppor commented Dec 5, 2016

I like that EasyDateFormat gets smaller. We should try to use standard libraries 😇

The library is now available at maven central: http://search.maven.org/#search%7Cga%7C1%7Ca%3A%22LGoodDatePicker%22

Locally tested: LGTM

Copy link
Member

@lenhard lenhard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it locally and it looks fine!

Please fix the comment by @koppor and get the library from maven central. Then you can merge.

@matthiasgeiger matthiasgeiger merged commit 8556e65 into master Dec 5, 2016
@matthiasgeiger matthiasgeiger deleted the move-to-lgooddatepicker branch December 5, 2016 13:19
Siedlerchr added a commit that referenced this pull request Dec 5, 2016
* upstream/master:
  builds.jabref.org: Keep html files and just remove *.exe, *.dmg, *.jar during upload of a new build
  Fix comment typo
  Fix typos in comments in .travis.yml
  Switch to LGoodDatePicker (#2340)
  Gradle build scans should only run on TravisCI, not on the other CI services
  Try scans.gradle.com
  Remove reference to GPL - we are MIT now
  fix date changes in medline fetcher results
  Fix #2336: shutdown is working again (#2338)

# Conflicts:
#	src/main/java/net/sf/jabref/model/database/BibDatabaseContext.java
Siedlerchr added a commit that referenced this pull request Dec 5, 2016
* upstream/master:
  builds.jabref.org: Keep html files and just remove *.exe, *.dmg, *.jar during upload of a new build
  Fix comment typo
  Fix typos in comments in .travis.yml
  Switch to LGoodDatePicker (#2340)
  Gradle build scans should only run on TravisCI, not on the other CI services
  Try scans.gradle.com
  Remove reference to GPL - we are MIT now
  fix date changes in medline fetcher results
  Fix #2336: shutdown is working again (#2338)
koppor added a commit to JabRef/jabref-koppor that referenced this pull request Dec 8, 2016
koppor added a commit to JabRef/jabref-koppor that referenced this pull request Dec 9, 2016
tobiasdiez pushed a commit to tobiasdiez/jabref that referenced this pull request Dec 10, 2016
* Switch to LGoodDatePicker

* document switch to LGoodDatePicker in external-libraries.txt

* use maven version of LGoodDatePicker and minor typo fixes
koppor added a commit that referenced this pull request Dec 11, 2016
koppor added a commit to JabRef/jabref-koppor that referenced this pull request Dec 14, 2016
koppor added a commit to JabRef/jabref-koppor that referenced this pull request Dec 14, 2016
koppor added a commit to JabRef/jabref-koppor that referenced this pull request Dec 15, 2016
koppor added a commit to JabRef/jabref-koppor that referenced this pull request Dec 15, 2016
koppor added a commit to JabRef/jabref-koppor that referenced this pull request Dec 16, 2016
koppor added a commit to JabRef/jabref-koppor that referenced this pull request Dec 17, 2016
koppor added a commit to JabRef/jabref-koppor that referenced this pull request Dec 17, 2016
koppor added a commit to JabRef/jabref-koppor that referenced this pull request Dec 17, 2016
koppor added a commit to JabRef/jabref-koppor that referenced this pull request Dec 19, 2016
koppor added a commit to JabRef/jabref-koppor that referenced this pull request Dec 19, 2016
koppor added a commit to JabRef/jabref-koppor that referenced this pull request Dec 21, 2016
koppor added a commit to JabRef/jabref-koppor that referenced this pull request Dec 25, 2016
koppor added a commit to JabRef/jabref-koppor that referenced this pull request Dec 26, 2016
koppor added a commit to JabRef/jabref-koppor that referenced this pull request Dec 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants