Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Use v8 engine for CSL #2250

Merged
merged 4 commits into from
Dec 5, 2016
Merged

[WIP] Use v8 engine for CSL #2250

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7507fe8
Add a dependency to com.eclipsesource.J2V8 (Java Bindings for V8) in …
shitikanth Nov 8, 2016
b1c4039
Make sure that V8 dependency is available.
shitikanth Nov 16, 2016
5ee4d79
Add entry for J2V8 in external-libraries.txt.
shitikanth Nov 16, 2016
c04f46b
Removed space from licence identifier.
shitikanth Nov 22, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions external-libraries.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,4 +174,9 @@ Project: Citeproc-Java
URL: http://michel-kraemer.github.io/citeproc-java/
Licence: Apache License, Version 2.0

Id: com.eclipse.j2v8
Project: J2V8
URL: https://github.com/eclipsesource/J2V8
Licence: EPL- 1.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you remove the space before 1.0 so it is a valid SPDX license identifier?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!


The last entry has to end with an empty line. Otherwise the entry is not present in About.html.